Skip to content

Conversation

@lieszkol
Copy link

@lieszkol lieszkol commented Sep 16, 2023

…ity with FiltaQuilla or QuickFilters?)

Perhaps due to incompatibility with FiltaQuilla or QuickFilters, the "Filters" add-on would completely stop working after certain special filters were defined. I propose adding some error handling to enable the add-on to continue functioning even in such cases.

…ity with FiltaQuilla or QuickFilters?)

Perhaps due to incompatibility with FiltaQuilla or QuickFilters, the "Filters" add-on would completely stop working after certain special filters were defined. Adding some error handling to enable the add-on to continue functioning even in such cases.
@ChristophKaser
Copy link
Owner

Thank you very much for your contribution!
The way it works around issues accessing the filter value however seems a bit like a hack to me - I would prefer it if getFilters() would simply log a warning message to the console and skipped filters it had issues converting.

Can you tell me more about the filter that causes the exception so I can try to reproduce the issue?

@lieszkol
Copy link
Author

I'm not familiar with the workings of the plugin, I am sure there is a better way to handle these errors. Unfortunately I have many filters and I was unable to idenfity which of them where throwing the exceptions. I suspect it may be one of the FiltaQuilla custom actions, which are quite useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants