Skip to content

Add error handling to deal with unexpected filter types (incompatibil… #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lieszkol wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add error handling to deal with unexpected filter types (incompatibil… #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions experiments/filters/implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,13 @@ var filters = class extends ExtensionCommon.ExtensionAPI {
retval.junkPercent = val.junkPercent;
break;
default:
retval.str = val.str;
// For some reason "val.str" throws 0x80070057 (NS_ERROR_ILLEGAL_VALUE), ignore such cases so as not to break the Filter button completely:
try {
retval.str = val.str;
}
catch (error) {
retval.str = "Filter button error interpreting filter: " + error.str;
}
break;
}
return retval;
Expand Down Expand Up @@ -125,7 +131,8 @@ var filters = class extends ExtensionCommon.ExtensionAPI {
async filterMatches(filterId, messageId) {
let filter = filterMap[filterId];
if (!filter) {
throw new Error('Invalid or stale filterId ' + filterId);
return false;
// This should only be used when debugging the add-on: throw new Error('Invalid or stale filterId ' + filterId);
}
let msg = context.extension.messageManager.get(messageId);

Expand Down