Skip to content

Conversation

@tomusdrw
Copy link
Member

Summary

The publish job failed because the inline Node.js script was being interpreted by the shell, causing syntax errors with template literals and variable substitution.

Changes

  • Moved the inline Node.js script to a file using cat <<'EOF' to prevent shell expansion of JS code.
  • Executed the script file using node.

Testing

This change ensures that JavaScript template literals (backticks) and ${} inside the script are passed correctly to Node.js without shell interference.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Refactors the .github/workflows/publish.yml to extract inline Node.js versioning logic into a dedicated update_versions.js file. The new script expands version management to update multiple package.json files (dist, darwin-arm64, linux-x64-gnu) by deriving versions from base versions and short SHA, and propagating changes to optionalDependencies.

Changes

Cohort / File(s) Summary
CI Workflow Versioning Refactor
.github/workflows/publish.yml
Replaces inline Node.js script with dedicated update_versions.js file. Expands versioning logic to update dist/package.json and native platform-specific packages (darwin-arm64, linux-x64-gnu) with versions derived from base version + short SHA. Propagates optionalDependencies version updates across all updated files.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main fix: resolving a publish workflow script quoting issue caused by shell interpretation.
Description check ✅ Passed The description clearly explains the problem (shell interpreting inline Node.js script causing syntax errors) and the solution (moving script to file using here-doc).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@tomusdrw tomusdrw merged commit fe6e357 into main Jan 20, 2026
4 checks passed
@tomusdrw tomusdrw deleted the fix-publish-workflow branch January 20, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants