-
Notifications
You must be signed in to change notification settings - Fork 205
Make "platform" optional #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR GoogleContainerTools#469 added this and added a default, which breaks container_structure_test on ARM. Let's remove the default so that we can choose whether we want to set a platform, restoring original behavior.
Summary of ChangesHello @TvdW, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build failure on ARM architectures by modifying the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the hardcoded linux/amd64 default for the platform attribute in the container_structure_test Bazel rule. This change fixes an issue for users on non-amd64 architectures like ARM by allowing the underlying container-structure-test tool to use its own architecture-aware default. I've added a suggestion to improve the documentation for this attribute to make the default behavior clearer to users.
| "platform": attr.string( | ||
| default = "linux/amd64", | ||
| doc = "Set platform if host is multi-platform capable (default \"linux/amd64\")", | ||
| doc = "Set platform if host is multi-platform capable", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve clarity for users of this rule, it would be helpful to mention what the default behavior is when platform is not specified. The underlying container-structure-test tool defaults to the host's architecture (linux/GOARCH), so mentioning examples for different architectures would be beneficial.
| doc = "Set platform if host is multi-platform capable", | |
| doc = "Set platform if host is multi-platform capable. If not set, it defaults to the host's platform, e.g., 'linux/amd64' or 'linux/arm64'." |
PR #469 added this and added a default, which breaks container_structure_test on ARM.
Let's remove the default so that we can choose whether we want to set a platform, restoring original behavior.
Fixes #542