Skip to content

Make "platform" optional #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TvdW wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make "platform" optional #543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bazel/container_structure_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ _attrs = {
doc = "See https://github.com/GoogleContainerTools/container-structure-test#running-file-tests-without-docker",
),
"platform": attr.string(
default = "linux/amd64",
doc = "Set platform if host is multi-platform capable (default \"linux/amd64\")",
doc = "Set platform if host is multi-platform capable",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve clarity for users of this rule, it would be helpful to mention what the default behavior is when platform is not specified. The underlying container-structure-test tool defaults to the host's architecture (linux/GOARCH), so mentioning examples for different architectures would be beneficial.

Suggested change
doc = "Set platform if host is multi-platform capable",
doc = "Set platform if host is multi-platform capable. If not set, it defaults to the host's platform, e.g., 'linux/amd64' or 'linux/arm64'."

),
"_runfiles": attr.label(default = "@bazel_tools//tools/bash/runfiles"),
"_windows_constraint": attr.label(default = "@platforms//os:windows"),
Expand Down