Skip to content

Eliminar is_siteadmin() para respetar capabilities locales y cambio de rol #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jairoserrano merged 14 commits into from
Jan 19, 2026
Merged

Eliminar is_siteadmin() para respetar capabilities locales y cambio de rol #31

jairoserrano merged 14 commits into from
Jan 19, 2026

Conversation

@IsaacDev2024
Copy link
Contributor

@IsaacDev2024 IsaacDev2024 commented Jan 18, 2026 •
edited
Loading

Este PR corrige la lógica de permisos del bloque para que respete el contexto del curso en lugar de los permisos globales del sitio.

Cambios realizados:

  • Se eliminaron las llamadas a is_siteadmin() y !is_siteadmin() en la lógica de acceso y generación de reportes.
  • Ahora el acceso se determina exclusivamente mediante has_capability('block/pluginname:viewreports', $context).
  • Negrilla en titulo principal del bloque para consistencia con los demás

Beneficios:

  • QA Mejorado: Permite a los administradores usar la función "Cambiar rol a -> Estudiante" y ver el bloque exactamente como lo vería un alumno.
  • Consistencia: Si un admin se matricula como estudiante en un curso, ahora aparecerá correctamente en los reportes y listas de clase en lugar de ser filtrado automáticamente.

IsaacDev2024 and others added 14 commits January 18, 2026 12:47
@IsaacDev2024
Refactor authorization logic in admin_view.php
f91b900 
Simplified authorization checks for report access by removing redundant site admin checks.
@IsaacDev2024
Remove site admin check from student filtering logic
2a38892
@IsaacDev2024
Simplify report view permissions check
ea84267 
Removed site admin check from report view permissions.
@IsaacDev2024
Refine report view capability check
9f3c63e 
Remove site admin check from report view capability.
@IsaacDev2024
Simplify report access checks in view_individual.php
968a734 
Refactor access checks to streamline report viewing logic.
@IsaacDev2024
Update CHANGELOG for version 2.0.4
a534b5c 
Removed redundant admin checks in key views to improve role detection and permissions system.
@IsaacDev2024
Bump version to 2.0.4 and update release notes
aa9d43d
@IsaacDev2024
Make header text bold in personality invitation block
2e3c28e
@IsaacDev2024
Make title bold in student invitation template
e046e84
@IsaacDev2024
Make test_completed heading bold in student results
f19e9d1
@IsaacDev2024
Update CHANGELOG for version 2.0.4 changes
d45093e 
Removed redundant admin checks in key views to improve role detection and permissions system. Added bold formatting to block title for better visibility.
@IsaacDev2024
Change test title to 'Personality Exploration'
feff21e
@serna0120
Update image links in README.md
74a9afd
@IsaacDev2024
Change icon from chart to eye in student results template
e38a212
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 19, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@IsaacDev2024 IsaacDev2024 mentioned this pull request Jan 19, 2026
Closed
@jairoserrano jairoserrano merged commit 1c4241f into ISCOUTB:main Jan 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IsaacDev2024 @jairoserrano @serna0120