Skip to content

Issue 53225: Unable to delete row from ehr_lookups.procedures #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-bpatel merged 3 commits into from
Sep 2, 2025
Merged

Issue 53225: Unable to delete row from ehr_lookups.procedures #1018

labkey-bpatel merged 3 commits into from
Sep 2, 2025

Conversation

@labkey-bpatel
Copy link
Contributor

@labkey-bpatel labkey-bpatel commented Aug 21, 2025 •
edited
Loading

Rationale

Issue 53225: Unable to delete row from ehr_lookups.procedures

The failure occured in LookupValidationHelper.verifyNotUsed() for EHR clients that did not have study.encounters table in their dataset.

Related Pull Requests

Changes

  • Update procedures.js trigger to use registerHandlerForQuery(), enabling it to be unregistered for EHR clients without a study.encounters table.
  • Update trigger scripts using LookupValidationHelper.verifyNotUsed() to add the script name to error messages (making it easier to trace the source since trigger failures often return unhelpful messages).

@labkey-bpatel labkey-bpatel mentioned this pull request Aug 21, 2025
Merged
@labkey-bpatel labkey-bpatel requested a review from bbimber August 21, 2025 18:18
@labkey-bpatel labkey-bpatel mentioned this pull request Aug 21, 2025
Merged
@bbimber
Copy link
Collaborator

bbimber commented Aug 21, 2025

@labkey-bpatel , will you update uses of verifyNotUsed() in onprcEHRModules?

@labkey-bpatel
Copy link
Contributor Author

labkey-bpatel commented Aug 21, 2025

@labkey-bpatel , will you update uses of verifyNotUsed() in onprcEHRModules?

Done! Please review LabKey/onprcEHRModules#1432

@labkey-bpatel labkey-bpatel mentioned this pull request Sep 1, 2025
Merged
@labkey-bpatel labkey-bpatel merged commit 0e15803 into release25.7-SNAPSHOT Sep 2, 2025
5 checks passed
@labkey-bpatel labkey-bpatel deleted the 25.7_fb_procedures_trigger branch September 2, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbimber bbimber bbimber approved these changes

@labkey-martyp labkey-martyp labkey-martyp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@labkey-bpatel @bbimber @labkey-martyp