Skip to content

fix ehr data validation queries #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ankurjuneja merged 2 commits into from
Oct 2, 2023
Merged

fix ehr data validation queries #670

ankurjuneja merged 2 commits into from
Oct 2, 2023

Conversation

@ankurjuneja
Copy link
Contributor

@ankurjuneja ankurjuneja commented Oct 2, 2023 •
edited
Loading

Rationale

This PR fixes the related PR for the centers that store dam and sire in different dataset than demographics

Related Pull Requests

Changes

  • use Id.parents.dam in place of dam from demographics

labkey-jeckels
labkey-jeckels reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might speed up the queries to use study.demographicsParents as the base query instead of starting with study.demographics and doing two separate lookup-based joins to it via Id.parents

@ankurjuneja ankurjuneja marked this pull request as ready for review October 2, 2023 18:30
@labkey-martyp
Copy link
Contributor

labkey-martyp commented Oct 2, 2023

It might speed up the queries to use study.demographicsParents as the base query instead of starting with study.demographics and doing two separate lookup-based joins to it via Id.parents

@ankurjuneja How's the perf after your refactors Ankur. Want to investigate Josh's suggestion here?

@ankurjuneja
Copy link
Contributor Author

ankurjuneja commented Oct 2, 2023

@labkey-martyp After fixing the slowest one, all 4 queries are loading in ~40-50 seconds

labkey-martyp
labkey-martyp approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@labkey-martyp labkey-martyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you're seeing one or two of these queries taking the majority of the load time, probably worth looking into Josh's suggestion on that one.

@ankurjuneja ankurjuneja merged commit 75d5b11 into develop Oct 2, 2023
@ankurjuneja ankurjuneja deleted the fb_fix47265 branch October 2, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels left review comments

@labkey-martyp labkey-martyp labkey-martyp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ankurjuneja @labkey-martyp @labkey-jeckels