-
Notifications
You must be signed in to change notification settings - Fork 10
Update HTSJDK and picard versions #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTSJDK and picard versions #1139
Conversation
|
Hi @labkey-jeckels: this should be a pretty perfunctory update, but I cant create PR branches on server/platform anymore. This PR is currently targeting release25.3-SNAPSHOT; however, I think I need someone with write permissions to:
There is a related change here: BimberLab/DiscvrLabKeyModules#343 Would it be possible for someone at LabKey to help make that update? Thanks in advance for any help. |
|
I've created the mirror of the FB. TeamCity is running now. |
|
Thanks |
|
@labkey-jeckels: note, my second commit here (BimberLab/DiscvrLabKeyModules#343) should address that FastqRunner failure. I'm not sure if my commit on that PR will re-trigger team city though. |
|
I believe that JBrowse failure is a timing problem (i've never seen that particular issue before: https://teamcity.labkey.org/buildConfiguration/LabKey_253Release_External_Discvr_ExternalModulesTestPostgres/3602051), not related to this change. Otherwise it seems to have passed. |
|
The JBrowse test passed on a rerun. The FastqRunner test failed on rerun, presumably because it's running against the LK fork of DiscvrLabKeyModules. Is the plan to merge your DiscvrLabKeyModules changes into the LK repo immediately afterwards? |
|
Team city doesn't pull from the same side of the fork? Yes, I can do a merge to the LK side at the same time. This would be LabKey/DiscvrLabkeyModules on the release25.3-SNAPSHOT branch, right? |
|
@labkey-jeckels, this PR cherry picks the FastqcRunner / picard version changes on release25.3-SNAPSHOT: LabKey/DiscvrLabKeyModules#376 |
This (and almost all other TeamCity builds) pull from the LabKey fork of the repo. The External/DISCVR projects pull from you copy of the repo. Correct on the merge target. |
|
@labkey-jeckels: OK. What would you like prior to approving this PR? Do you want to restart the failed DRTs (it didnt look like I could re-trigger them myself). I believe that release25.3-SNAPSHOT targeting PR/branch will should be picked up by TeamCity now, right? |
I retriggered them manually and see your commits in the list of changes. Assuming it passes as expected I will go ahead and merge this PR. |
|
excellent, thank you |
72c0218
into
LabKey:release25.3-SNAPSHOT
No description provided.