chore: upgrade ethereumjs packages #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
4 tasks
Member
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
danroc
reviewed
Feb 28, 2025
danroc
reviewed
Feb 28, 2025
danroc
reviewed
Feb 28, 2025
danroc
reviewed
Feb 28, 2025
danroc
approved these changes
Feb 28, 2025
matthewwalsh0
added a commit
to MetaMask/core
that referenced
this pull request
Mar 5, 2025
## Explanation Align `@ethereumjs/*` package versions to avoid any risk of incompatibility and simplify future maintenance. Upgrade originally required by `@metamask/transaction-controller` to support EIP-7702 transactions. ## References - `@metamask/accounts` [PR](MetaMask/accounts#209) ## Changelog See changelogs. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Michele Esposito <michele@esposito.codes> Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
This was referenced Mar 19, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
…` (due to latest `@ethereumjs` upgrade) (#253) This PR will fix the ledger sign transaction issue due to this ethereumjs upgrade PR #209 and basically the ethereumjs upgrade code change make the transaction rawTxHex contain `0x` prefix which is not valid for to @ledgerhq/hw-eth-app clearSignTransaction function. that functions expect a rawTxHex without `0x` prefix. <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes [#31004](MetaMask/metamask-extension#31004) * See: #67890 --> <!-- Are there any examples of this change being used in another repository? When considering changes to the MetaMask module template, it's strongly preferred that the change be experimented with in another repository first. This gives reviewers a better sense of how the change works, making it less likely the change will need to be reverted or adjusted later. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade all
@ethereumjs/*packages:@ethereumjs/util-^8.1.0>^9.1.0@ethereumjs/tx-^4.2.0>^5.4.0@ethereumjs/common-^3.2.0>^4.4.0Necessary to align with
@metamask/transaction-controllerwhich requires the latest versions to support EIP-7702 transactions.Minor refactors to support breaking changes, primarily:
Bufferusage replaced withUint8Array.bufferToHex>bytesToHexTransactionConstructor >LegacyTransaction.fromTxDataTxData>TypedTxDatagetMessageToSign(false)>getMessageToSigngetMessageToSign(true)>getHashedMessageToSignNotes
bytesToHexfrom@metamask/utilsrather than@ethereumjs/utilsfor additional control and performance.Buffer.