Skip to content

Conversation

@OscarBosigas
Copy link
Owner

No description provided.

Copy link
Contributor

@pushdev-code pushdev-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exercise is not completed, double check the requirements of the exercise: https://pushdev-code.github.io/css-tutorial/2-positioning/

@@ -0,0 +1,19 @@
header {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This element is not being sticky. double check the functionality.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set a top property so the sticky works.

@@ -0,0 +1,19 @@
header {
background-color: black;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

green borders are missing.

position: sticky;
}

nav {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blue borders and 200px of width are missing.

}

section {
margin-left: 300px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: red border and it’s 200px away from its left.

footer {
background-color: brown;
font-style: italic;
position: fixed;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orange border and it’s fixed to the bottom.

Copy link
Contributor

@pushdev-code pushdev-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, just one tweak.

@@ -0,0 +1,19 @@
header {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set a top property so the sticky works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants