-
Notifications
You must be signed in to change notification settings - Fork 6
Feature/positioning #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Feature/positioning box model
Complements css exercises for grid, media queries and layouts
pushdev-code
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exercise is not completed, double check the requirements of the exercise: https://pushdev-code.github.io/css-tutorial/2-positioning/
| @@ -0,0 +1,19 @@ | |||
| header { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This element is not being sticky. double check the functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to set a top property so the sticky works.
| @@ -0,0 +1,19 @@ | |||
| header { | |||
| background-color: black; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
green borders are missing.
| position: sticky; | ||
| } | ||
|
|
||
| nav { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blue borders and 200px of width are missing.
2-positioning/style.css
Outdated
| } | ||
|
|
||
| section { | ||
| margin-left: 300px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: red border and it’s 200px away from its left.
| footer { | ||
| background-color: brown; | ||
| font-style: italic; | ||
| position: fixed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orange border and it’s fixed to the bottom.
pushdev-code
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there, just one tweak.
| @@ -0,0 +1,19 @@ | |||
| header { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to set a top property so the sticky works.
No description provided.