refactor(notification): 알림 api 로직 및 메시지 수정, 읽음 처리 기능 구현 #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ckwogus37
approved these changes
Nov 19, 2024
| List<Notification> unreadNotifications = notificationRepository.findUnreadNotificationsByUserId(userId); | ||
| unreadNotifications.forEach(Notification::markAsRead); | ||
| notificationRepository.saveAll(unreadNotifications); | ||
| } |
Contributor
There was a problem hiding this comment.
읽지 않은 모든 알람들의 is_read값을 true로 바꾸시려는 의도라면,
현재(조회 -> 수정 -> 저장) 방법도 좋지만, Update 쿼리(수정)를 사용하는 방법도 추천드려봅니다!
제가 루틴 완료를 매일 초기화하는 로직과 유사한 것 같아서 생각났습니다!
Update notifications n SET n.isRead = TRUE WHERE n.userId = :userId AND n.isRead IS FALSE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests
작업한 내용
PR Point
📸 스크린샷
논의 사항 (선택)
closed #355