-
Notifications
You must be signed in to change notification settings - Fork 2
refactor(notification): 알림 api 로직 및 메시지 수정, 읽음 처리 기능 구현 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0510b35
refactor(notification): 알림 로직 수정
habbiness f81534e
feat(notification): 읽음 필드 추가
habbiness 2c2afdf
feat(notification): 읽음 로직 추가
habbiness 74c52bf
chore: db 설정
habbiness cf3ebcc
feat(notification): 알림 추가 로직 작성
habbiness d35cfb2
refactor: 로직 변경
habbiness 63cda8a
refactor(notification): url 수정
habbiness c0cecd3
refactor: 알림 전체 조회 로직 수정
habbiness File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/main/java/site/coach_coach/coach_coach_server/common/domain/RelationFunctionEnum.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| package site.coach_coach.coach_coach_server.common.domain; | ||
|
|
||
| public enum RelationFunctionEnum { | ||
| review, ask, like, match, refusal, cancel | ||
| review, ask, like, match, refusal, cancel, routine, request | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 8 additions & 1 deletion
9
...a/site/coach_coach/coach_coach_server/notification/repository/NotificationRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,16 @@ | ||
| package site.coach_coach.coach_coach_server.notification.repository; | ||
|
|
||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.data.jpa.repository.Modifying; | ||
| import org.springframework.data.jpa.repository.Query; | ||
| import org.springframework.data.repository.query.Param; | ||
|
|
||
| import site.coach_coach.coach_coach_server.notification.domain.Notification; | ||
|
|
||
| public interface NotificationRepository extends JpaRepository<Notification, Long> { | ||
| int countByUser_UserId(Long userId); | ||
| int countByUser_UserIdAndIsReadFalse(Long userId); | ||
|
|
||
| @Modifying | ||
| @Query("UPDATE Notification n SET n.isRead = TRUE WHERE n.user.userId = :userId AND n.isRead = FALSE") | ||
| void updateIsReadByUserID(@Param("userId") Long userId); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
src/main/resources/db/migration/V23__modify_notification_table.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| ALTER TABLE `coachcoach`.`notifications` | ||
| ADD COLUMN `is_read` BIT(1) NOT NULL DEFAULT b'0' AFTER `relation_function`, | ||
| CHANGE COLUMN `message` `message` VARCHAR(200) NOT NULL , | ||
| CHANGE COLUMN `relation_function` `relation_function` ENUM('ask', 'like', 'review', 'match', 'refusal', 'cancel', 'routine', 'request') NOT NULL ; | ||
|
|
||
| ALTER TABLE `coachcoach`.`notifications` | ||
| ADD COLUMN `coach_id` BIGINT NOT NULL AFTER `user_id`; | ||
| ALTER TABLE `coachcoach`.`notifications` | ||
| ADD INDEX `fk_notifications_coach_id_idx` (`coach_id` ASC) VISIBLE; | ||
| ALTER TABLE `coachcoach`.`notifications` | ||
| ADD CONSTRAINT `fk_notifications_coach_id` | ||
| FOREIGN KEY (`coach_id`) | ||
| REFERENCES `coachcoach`.`users` (`user_id`); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
읽지 않은 모든 알람들의 is_read값을 true로 바꾸시려는 의도라면,
현재(조회 -> 수정 -> 저장) 방법도 좋지만, Update 쿼리(수정)를 사용하는 방법도 추천드려봅니다!
제가 루틴 완료를 매일 초기화하는 로직과 유사한 것 같아서 생각났습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 추천감사합니당!