Cache LevelChunk in Chunk::rebuild #232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Wouldn't this cause issues if a |
Contributor
Author
No, the region only encompasses one LevelChunk |
BrentDaMage
requested changes
Dec 23, 2025
Collaborator
BrentDaMage
left a comment
BrentDaMage
left a comment
There was a problem hiding this comment.
Please comment out t
| { | ||
| for (tp.x = min.x; tp.x < max.x; tp.x++) | ||
| { | ||
| TileID tile = region.getTile(tp); |
Collaborator
There was a problem hiding this comment.
Please comment out line 158 instead of removing it, then put comment above explaining why this change was made. In the event of a regression way down the line, it will make this easier to find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.