Skip to content

Cache LevelChunk in Chunk::rebuild #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluepilledgreat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cache LevelChunk in Chunk::rebuild #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/client/renderer/Chunk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ void Chunk::rebuild()
TileRenderer tileRenderer(t, &region);

TilePos tp(min);
LevelChunk* chunk = region.getChunkAt(tp);
for (int layer = Tile::RENDER_LAYERS_MIN; layer <= Tile::RENDER_LAYERS_MAX; layer++)
{
bool started = false, rendered = false, renderNextLayer = false;
Expand All @@ -155,7 +156,7 @@ void Chunk::rebuild()
{
for (tp.x = min.x; tp.x < max.x; tp.x++)
{
TileID tile = region.getTile(tp);
Copy link
Collaborator

@BrentDaMage BrentDaMage Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment out line 158 instead of removing it, then put comment above explaining why this change was made. In the event of a regression way down the line, it will make this easier to find.

TileID tile = chunk->getTile(tp);
if (tile <= 0) continue;

if (!started)
Expand Down