Skip to content

Conversation

@art0007i
Copy link
Contributor

now I'm pretty sure this doesn't work exactly if your arguments actually include quotes.
for example hello"world would get escaped as "hello"world" which idk how this gets parsed into arguments, maybe hello, world". not sure but I'm not gonna test or fix it, someone else can do it. anyway you'd have to be a psycho to put quotes in the middle of any of these launch args

@hazre hazre self-requested a review September 11, 2025 12:21
Copy link
Member

@hazre hazre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and seems to work. lgtm

@hazre
Copy link
Member

hazre commented Sep 11, 2025

I changed out GetCommandLineArgs for Environment.CommandLine.

GetCommandLineArgs stripes out the quotations, which is what we trying to prevent. I just got the function from here: https://stackoverflow.com/a/28714169

@art0007i art0007i merged commit 7378576 into master Sep 11, 2025
2 checks passed
@hazre hazre deleted the escape-quotes branch September 11, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants