Skip to content

add quotes around all arguments, to prevent args getting split incorrectly #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
art0007i merged 3 commits into from
Sep 11, 2025
Merged

add quotes around all arguments, to prevent args getting split incorrectly #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31550c1
add quotes around all arguments, to prevent args getting split incorr…
art0007i Sep 11, 2025
0e54c20
Merge remote-tracking branch 'origin/master' into escape-quotes
hazre Sep 11, 2025
2c6512f
Switch out GetCommandLineArgs for Environment.CommandLine
hazre Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion RenderiteHook/Plugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,37 @@ public static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructio
public static string OnStartRenderer(string args)
{
CopyDoorstopFiles(Engine.Current.RenderSystem);
var newArgs = string.Join(' ', [args, .. Environment.GetCommandLineArgs().Skip(1)]);

var originalArgs = GetOriginalCommandLineArgs();
var newArgs = string.IsNullOrEmpty(originalArgs) ? args : args + " " + originalArgs;
Log.LogInfo($"Starting renderer with args: {newArgs}");
return newArgs;
}

private static string GetOriginalCommandLineArgs()
{
string str = Environment.CommandLine;

if (str.StartsWith("\"") && str.Length > 1)
{
int ix = str.IndexOf("\"", 1);
if (ix != -1)
{
str = str.Substring(ix + 1).TrimStart();
}
}
else
{
int ix = str.IndexOf(" ");
if (ix != -1)
{
str = str.Substring(ix + 1).TrimStart();
}
}

return str;
}

private static void CopyDoorstopFiles(RenderSystem renderSystem)
{
try
Expand Down