Fix translation of ArgumentError for filters in Liquid::Variable#render #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#111 introduced a regression where ArgumentError exceptions during filtering aren't getting translated to Liquid::ArgumentError in the Liquid::Variable#render when it contains a Liquid::C::Expression. This exception handling isn't normally needed for Liquid::C::Expression, so it was only being done for Liquid::C::BlockBody#render_to_output_buffer, but it is needed if we are doing filtering.
Solution
Introduce a Liquid::C::VariableExpression class that inherits from Liquid::C::Expression and wraps the evaluate method with a rescue handler to translate the ArgumentError exceptions into Liquid::ArgumentError.