Remove liquid expression parse patch #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanahsmith
commented
Jul 18, 2022
| strategy: | ||
| matrix: | ||
| entry: | ||
| - { ruby: '2.5', allowed-failure: false } |
Contributor
Author
There was a problem hiding this comment.
This is needed because of ruby liquid dropping support for EOL ruby versions (Shopify/liquid#1578)
Contributor
|
Edit: Ignore that last, it was because of local changes I had made while debugging myself, sorry. |
samdoiron
approved these changes
Jul 19, 2022
Instead, parse_context.parse_expression should generally be used. If a constant expression is desired, then Liquid::C::Expression can be used.
dylanahsmith
force-pushed
the
remove-liquid-expression-parse-patch
branch
from
40f8336 to
4940ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@samdoiron found a bug in #154, where
parse_context.parse_expressionwould not respectdisable_liquid_c_nodes: true, because even though that would make sure that Liquid::Expression.ruby_parse gets used, it would internally call the hard codedLiquid::Expression.parsethat would useLiquid::C::Expression.lax_parse.Solution
Get rid of the Liquid::Expression.parse monkey patch and instead require the application to use
Liquid::C::Expression.parseif they really want to create a constant Liquid::C::Expression object.