Confirmation metadata field #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhmirin-s
requested review from
BurningAXE,
alex-vt,
alexandr-simprints and
meladRaouf
BurningAXE
reviewed
Sep 23, 2025
| * @param userId identifies which user is making a request to Simprints ID. Can be any arbitrary String. | ||
| * @param sessionId identifies the identification session. | ||
| * @param selectedGuid the GUID that was confirmed in the host app. | ||
| * @param metadata optional metadata to attach to the registration if provided. |
Contributor
There was a problem hiding this comment.
"to attach to the confirmation if provided"?
Contributor
Author
There was a problem hiding this comment.
Will fix in a separate PR.
BurningAXE
reviewed
Sep 23, 2025
| project.version = "2025.2.2" | ||
| ext { | ||
| VERSION_CODE = 202502001 | ||
| VERSION_CODE = 202502002 |
Contributor
There was a problem hiding this comment.
Hm, how is this version code formed?
Contributor
Author
There was a problem hiding this comment.
It matches the version name, but it doesn't really matter for libraries, Maven central only uses the string.
Contributor
There was a problem hiding this comment.
But why are there two 0s in front of the patch part?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.