Skip to content

Confirmation metadata field #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 2 commits into from
Sep 23, 2025
Merged

Confirmation metadata field #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7f1fd
Add optional metadata field to confirmation request
luhmirin-s Sep 23, 2025
7861f98
Library version bump
luhmirin-s Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
**Installation**

```
implementation 'com.simprints:libsimprints:2025.2.1'
implementation 'com.simprints:libsimprints:2025.2.2'
```

[Documentation](https://simprints.gitbook.io/docs/development/simprints-for-developers/integrating-with-simprints)
Expand All @@ -20,5 +20,5 @@ implementation 'com.simprints:libsimprints:2025.2.1'
maven("https://oss.sonatype.org/content/repositories/snapshots")

// In app level gradle file
implementation 'com.simprints:libsimprints:2025.2.1-SNAPSHOT'
implementation 'com.simprints:libsimprints:2025.2.2-SNAPSHOT'
```
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ repositories {
mavenCentral()
}

project.version = "2025.2.1"
project.version = "2025.2.2"
ext {
VERSION_CODE = 202502001
VERSION_CODE = 202502002
Copy link
Contributor

@BurningAXE BurningAXE Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, how is this version code formed?

Copy link
Contributor Author

@luhmirin-s luhmirin-s Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matches the version name, but it doesn't really matter for libraries, Maven central only uses the string.

Copy link
Contributor

@BurningAXE BurningAXE Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why are there two 0s in front of the patch part?

}

android {
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/com/simprints/libsimprints/contracts/SimprintsRequest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,18 +113,21 @@ sealed class SimprintsRequest {
* @param userId identifies which user is making a request to Simprints ID. Can be any arbitrary String.
* @param sessionId identifies the identification session.
* @param selectedGuid the GUID that was confirmed in the host app.
* @param metadata optional metadata to attach to the registration if provided.
Copy link
Contributor

@BurningAXE BurningAXE Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to attach to the confirmation if provided"?

Copy link
Contributor Author

@luhmirin-s luhmirin-s Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a separate PR.

*/
data class ConfirmIdentity(
override val projectId: String,
override val userId: String,
val sessionId: String,
val selectedGuid: String,
val metadata: Metadata? = null,
) : SimprintsRequest() {
override fun toIntent() = Intent(Constants.SIMPRINTS_CONFIRM_IDENTITY_INTENT)
.appendAuthFields(projectId, userId)
.appendRequestMetaInformation()
.putExtra(Constants.SIMPRINTS_SESSION_ID, sessionId)
.putExtra(Constants.SIMPRINTS_SELECTED_GUID, selectedGuid)
.appendOptionalMetadata(metadata)
}

/**
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/com/simprints/libsimprints/contracts/SimprintsRequestTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,15 @@ class SimprintsRequestTest {
userId = "user-id",
sessionId = "session-id",
selectedGuid = "guid",
metadata = Metadata().put("key", "value"),
).toIntent()

assertEquals(Constants.SIMPRINTS_CONFIRM_IDENTITY_INTENT, intent.action)
assertEquals("project-id", intent.getStringExtra(Constants.SIMPRINTS_PROJECT_ID))
assertEquals("user-id", intent.getStringExtra(Constants.SIMPRINTS_USER_ID))
assertEquals("session-id", intent.getStringExtra(Constants.SIMPRINTS_SESSION_ID))
assertEquals("guid", intent.getStringExtra(Constants.SIMPRINTS_SELECTED_GUID))
assertEquals(METADATA_JSON, intent.getStringExtra(Constants.SIMPRINTS_METADATA))
}

@Test
Expand Down