Fix/update block workflow #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # hardcoded default workflow | ||
| continue | ||
| existing_workflow_id = w.id | ||
| if w.category != "INITIAL": |
Collaborator
There was a problem hiding this comment.
wouldn't this break if we'd only have INITIAL workflow since existing_workflow_id would never be defined?
Collaborator
Author
There was a problem hiding this comment.
I created a new task to share this example:
Each block in task.blocks contains the workflow attribute (list) with categories: FINAL and INITIAL, even when the block's workflow hasn't been updated. We always have FINAL and INITIAL workflows present on new task/block creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_block_workflow() currently does not check if the existing_workflow_id is the "FINAL" workflow.
Issue 1:
This causes the existing_workflow_id to become assigned to the "INITIAL" workflow, which can cause a patch error if the FINAL workflow does not equal the INITIAL workflow.
Issue 2:
This also prevents the blocks FINAL workflow from being patched back to the INITIAL workflow