Skip to content

Fix/update block workflow #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattkrain wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/update block workflow #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
062d95e
Update tasks.py
mattkrain Nov 11, 2025
fe3858f
Merge branch 'main' into fix/update_block_workflow
mattkrain Nov 11, 2025
a557cfd
Update test: test_update_block_workflow()
mattkrain Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/albert/collections/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ def update_block_workflow(
if w.name == "No Parameter Group" and len(b.workflow) > 1:
# hardcoded default workflow
continue
existing_workflow_id = w.id
if w.category != "INITIAL":
Copy link
Collaborator

@prasad-albert prasad-albert Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this break if we'd only have INITIAL workflow since existing_workflow_id would never be defined?

Copy link
Collaborator Author

@mattkrain mattkrain Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I created a new task to share this example:
Each block in task.blocks contains the workflow attribute (list) with categories: FINAL and INITIAL, even when the block's workflow hasn't been updated. We always have FINAL and INITIAL workflows present on new task/block creation.

existing_workflow_id = w.id
if existing_workflow_id == workflow_id:
logger.info(f"Block {block_id} already has workflow {workflow_id}")
return None
Expand Down
14 changes: 8 additions & 6 deletions tests/collections/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
TaskCategory,
TaskSearchItem,
)
from albert.resources.workflows import Workflow
from tests.utils.test_patches import change_metadata, make_metadata_update_assertions


Expand Down Expand Up @@ -106,21 +107,22 @@ def test_add_block(client: Albert, seeded_tasks, seeded_workflows, seeded_data_t


def test_update_block_workflow(
client: Albert, seeded_tasks, seeded_workflows, seeded_data_templates
client: Albert, seeded_tasks, seeded_workflows: list[Workflow],
):
task = [x for x in seeded_tasks if isinstance(x, PropertyTask)][0]
task: PropertyTask = [x for x in seeded_tasks if isinstance(x, PropertyTask)][0]
# in case it mutated
task = client.tasks.get_by_id(id=task.id)
starting_blocks = len(task.blocks)
block_id = task.blocks[0].id
new_workflow = [x for x in seeded_workflows if x.id != task.blocks[0].workflow][0]
new_workflow: Workflow = [workflow for workflow in seeded_workflows if workflow.id != task.blocks[0].workflow[0].id][0]
client.tasks.update_block_workflow(
task_id=task.id, block_id=block_id, workflow_id=new_workflow.id
)
updated_task = client.tasks.get_by_id(id=task.id)
updated_task: PropertyTask = client.tasks.get_by_id(id=task.id)
assert len(updated_task.blocks) == starting_blocks
updated_block = [x for x in updated_task.blocks if x.id == block_id][0]
assert new_workflow.id in [x.id for x in updated_block.workflow]
updated_block = [block for block in updated_task.blocks if block.id == block_id][0]
# Block's FINAL Workflow ID == New Workflow ID
assert new_workflow.id == updated_block.workflow[0].id


def test_task_get_history(client: Albert, seeded_tasks):
Expand Down