refactor: Update most frequently updating groups to run on Thursdays #3323
Conversation
At least two of the named groups in our renovate config are spammy sending out multiple PRs in a given day and can be overwhelming for the caretaker. Switching them to Thursdays means all the updates will happen then on the first day of the cycle, allowing the rest of the time as caretaker to be less noisy.
thePunderWoman
added
the
action: review
| matchUpdateTypes: ['digest', 'patch', 'minor'], | ||
| matchManagers: ['npm'], | ||
| matchBaseBranches: ['main'], | ||
| schedule: ['* 5-12 * * 4'], // 5:00 am am to 12:00 pm Every Thursday |
There was a problem hiding this comment.
What time zone is this in? 5am to 12pm in PST is 2pm to 9pm which is later than we would like for this to run
There was a problem hiding this comment.
If I recall the timezone is specified at the top of the file. It's Rome time.
There was a problem hiding this comment.
Indeed the TZ is Rome. You have a typo in the comment.
Also consider using a human readable version of the schedule example:
schedule: ['after 6am and before 10am on Thursday'], There was a problem hiding this comment.
Is there a particular reason we're using Rome? Why not switch it to UTC?
There was a problem hiding this comment.
What time zone is this in? 5am to 12pm in PST is 2pm to 9pm which is later than we would like for this to run
I was basically looking at other schedules in the file. A lot of them seem to be morning Rome time.
There was a problem hiding this comment.
Given the time zone, 5am to noon Rome time would be 8 PM the previous day to 3 AM PST. Should we leave that? Should I change it to later? What's the preference here?
| { | ||
| groupName: 'bazel dependencies', | ||
| matchManagers: ['bazel', 'bazel-module'], | ||
| schedule: ['* 5-12 * * 4'], // 5:00 am am to 12:00 pm Every Thursday |
There was a problem hiding this comment.
NIT: consider using a human readable version
There was a problem hiding this comment.
I was following the renovate documentation, which says cron is the recommendation. Apparently the human readable version is from a deprecated dependency.
There was a problem hiding this comment.
Here's the direct quote from the documentation:
"Renovate supports the standard Cron syntax, as well as deprecated support for a subset of Later syntax. We recommend you always use Cron syntax, due to its superior testing and robustness. Config support questions are no longer accepted for Later syntax problems - you will be recommended to use Cron instead."
https://docs.renovatebot.com/configuration-options/#schedule
There was a problem hiding this comment.
In general it looks good, but I want to understand a bit more somethings you comment in your commit message
"renovate config are spammy sending out multiple PRs in a given day and can be overwhelming for the caretaker".
These groups are schedule to open PR on Monday, Wednesday and Friday between 6am - 10am CET time https://github.com/thePunderWoman/dev-infra/blob/c0dada5f91bcf41c4f0706a7b01edf51f300d4a2/renovate-presets/default.json5#L9, so this the issue might be something else? Do you have an example?
For the NPM group updates can we choose a date closer to the release? (Wednesday maybe)?
The reason being, is that If an NPM package is release on Monday, waiting an extra week for package availability since it will be available not in the current week release but the next one slows down our delivery cycle and limits early visibility into potential bugs during the next period.
Increase the prConcurrentLimit
Since we are reducing the frequency of these dependency updates from three times a week to once a week, we should increase our concurrent PR limit. If we don't, we risk a significant backlog where updates are delayed by an additional week. I recommend increasing prConcurrentLimit from 8 to 10 (or higher) to ensure Renovate can clear the queue within its new, limited window.
|
@alan-agius4 Responding to your comments:
|
3 participants
At least two of the named groups in our renovate config are spammy sending out multiple PRs in a given day and can be overwhelming for the caretaker. Switching them to Thursdays means all the updates will happen then on the first day of the cycle, allowing the rest of the time as caretaker to be less noisy.