refactor: Update most frequently updating groups to run on Thursdays #3323
+4
−2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,8 +8,8 @@ | |
| // Schedule Renovate to run during off-peak hours | ||
| schedule: ['after 6am and before 10am on Monday, Wednesday, Friday'], | ||
|
|
||
| prConcurrentLimit: 12, | ||
| prHourlyLimit: 8, | ||
| timezone: 'Europe/Rome', | ||
|
|
||
| // Commit and PR customization | ||
|
|
@@ -74,6 +74,7 @@ | |
| matchUpdateTypes: ['digest', 'patch', 'minor'], | ||
| matchManagers: ['npm'], | ||
| matchBaseBranches: ['main'], | ||
| schedule: ['* 5-12 * * 4'], // 5:00 am am to 12:00 pm Every Thursday | ||
| }, | ||
|
|
||
| // ============================================================================ | ||
|
|
@@ -90,6 +91,7 @@ | |
| { | ||
| groupName: 'bazel dependencies', | ||
| matchManagers: ['bazel', 'bazel-module'], | ||
| schedule: ['* 5-12 * * 4'], // 5:00 am am to 12:00 pm Every Thursday | ||
|
Contributor
There was a problem hiding this comment. NIT: consider using a human readable version
Contributor
Author
There was a problem hiding this comment. I was following the renovate documentation, which says cron is the recommendation. Apparently the human readable version is from a deprecated dependency.
Contributor
Author
There was a problem hiding this comment. Here's the direct quote from the documentation: "Renovate supports the standard Cron syntax, as well as deprecated support for a subset of Later syntax. We recommend you always use Cron syntax, due to its superior testing and robustness. Config support questions are no longer accepted for Later syntax problems - you will be recommended to use Cron instead." https://docs.renovatebot.com/configuration-options/#schedule |
||
| }, | ||
|
|
||
| // Group GitHub Actions workflow | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What time zone is this in? 5am to 12pm in PST is 2pm to 9pm which is later than we would like for this to run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I recall the timezone is specified at the top of the file. It's Rome time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed the TZ is Rome. You have a typo in the comment.
Also consider using a human readable version of the schedule example:
schedule: ['after 6am and before 10am on Thursday'],There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason we're using Rome? Why not switch it to UTC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was basically looking at other schedules in the file. A lot of them seem to be morning Rome time.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the time zone, 5am to noon Rome time would be 8 PM the previous day to 3 AM PST. Should we leave that? Should I change it to later? What's the preference here?