Skip to content

Conversation

Copy link

Copilot AI commented Jan 8, 2026

Addresses code review feedback to improve debuggability when GetAllLfsFiles returns an empty map.

Changes

  • Added log message when dry-run output is empty to distinguish "no LFS files to push" from error conditions
  • Removed unnecessary string conversion (out is already string from RunLfsPushDryRun)
out, err := RunLfsPushDryRun(ctx, repoDir, spec, logger)
if err != nil {
    return nil, err
}

// Log when dry-run returns no output to help with debugging
if strings.TrimSpace(out) == "" {
    logger.Printf("No LFS files to push (dry-run returned no output)")
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 8, 2026 23:14
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on feature/improve on push filter Add logging when git lfs push --dry-run returns empty output Jan 8, 2026
Copilot AI requested a review from bwalsh January 8, 2026 23:18
@bwalsh bwalsh marked this pull request as ready for review January 8, 2026 23:21
Copilot AI review requested due to automatic review settings January 8, 2026 23:21
@bwalsh bwalsh merged commit 75b253f into feature/improve-on-push-filter Jan 8, 2026
4 checks passed
@bwalsh bwalsh deleted the copilot/sub-pr-127 branch January 8, 2026 23:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a logging statement to improve debuggability when GetAllLfsFiles encounters an empty dry-run output from git lfs push.

Key changes:

  • Added informational log message when git lfs push --dry-run returns no output, helping distinguish between "no LFS files to push" and error conditions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants