Feature/improve on push filter #127

bwalsh · 2026-01-08T18:19:58Z

Move DRS object preparation to pre-push hook, improve LFS dry-run handling, and expand tooling/docs

Summary

Add a dedicated git drs prepush hook command that prepares DRS objects before invoking git lfs pre-push, buffering stdin safely for the child process.
Shift LFS object discovery to a git lfs push --dry-run flow with remote/ref resolution and pointer safeguards, ensuring UpdateDrsObjects operates on what will actually be pushed.
Install a pre-push hook during git drs init, and document the prepush workflow in developer and command references.
Improve logging to include PID-prefixed entries and more accurate caller location for thread-safe logging.
Add a tests/monorepos/list-indexd.sh utility for listing Indexd records tied to a resource path in a Kubernetes-hosted Postgres instance.

Architecture Changes

DRS object preparation moved from transfer-time to pre-push: the pre-push hook now invokes UpdateDrsObjects before git lfs pre-push, while transfer no longer preloads DRS objects, making the push pipeline more predictable and minimizing transfer-side work.

LFS candidate selection now follows Git LFS’s own dry-run: GetAllLfsFiles uses git lfs push --dry-run plus remote/ref resolution to target what would be pushed, with safeguards for empty pointers and small pointer files.

Initialization now provisions a pre-push hook: git drs init installs or updates the pre-push hook to route through git drs prepush for consistent pre-push behavior.

old

flowchart TD
  A[git push] --> B[git lfs pre-push]
  subgraph prepush[pre-push hook; runs once]
      subgraph xfer[N concurrent]
        B --> C[git drs transfer]
        C --> D[UpdateDrsObjects]
        D --> E[GetAllLfsFiles]
        E --> F[git lfs status; all files from all commits] 
      end 
  end

new

flowchart TD
  A[git push] --> B[hook]
  subgraph prepush[pre-push hook; runs once]
    B --> C[git drs prepush]
    C --> D[UpdateDrsObjects]
    D --> E[GetAllLfsFiles]
    E --> F[git lfs push --dry-run ; only files from this commit set] 
    F --> G[git lfs pre-push]
  end 
  subgraph xfer[N concurrent]
  G --> H[git drs transfer]
  end

pre-push now orchestrates DRS preparation before handing off to Git LFS, while transfer focuses strictly on upload/download work.

Links to Issues

Reviewer Testing

Verify pre-push hook preparation flow
Goal: Confirm git drs prepush prepares DRS objects before Git LFS pre-push.

# From a Git repo initialized with git-drs:
git drs init
git drs remote add gen3 <name> --url <url> --cred <cred> --project <proj> --bucket <bucket>
git drs remote set <name>

# Add/modify an LFS-tracked file, then push:
git lfs track "*.dat"
git add .gitattributes
git add path/to/file.dat
git commit -m "Add test LFS file"
git push

Expected: The pre-push hook should run git drs prepush, prepare DRS objects, then invoke git lfs pre-push via the buffered stdin flow. This behavior is implemented in cmd/prepush/main.go and installed by git drs init in cmd/initialize/main.go.

Validate LFS dry-run selection for pushed files
Goal: Ensure only LFS files that would be pushed are considered.

# In a repo with LFS files, run:
git lfs push --dry-run origin HEAD

Expected: GetAllLfsFiles uses the dry-run output to determine which LFS objects to prepare, including remote/ref resolution and pointer safeguards described in drsmap/drs_map.go.

(Optional) Confirm new utility script for Indexd records
Goal: List Indexd records for a resource path from the test cluster.

# From tests/monorepos:
./list-indexd.sh <pod-name> <postgres-password> "/programs/<program>/projects/<project>"
Expected: The script prints DIDs for the specified resource path by running SQL inside the pod. Script usage and behavior are defined in tests/monorepos/list-indexd.sh.

Detect pushing lfs pointer files

Given:

$ mkdir LFS-POINTERS
$ cd LFS-POINTERS/
$ cat > dummy-file.txt
version https://git-lfs.github.com/spec/v1
oid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393
size 12345
$ cd ..
$ git lfs track "LFS-POINTERS/**"
Tracking "LFS-POINTERS/**"
$ git add LFS-POINTERS/
$ git commit -am "adds LFS-POINTERS/"

The system will respond with:

$ git push origin main 
WARNING: Detected upload of lfs pointer file LFS-POINTERS/dummy-file.txt
Git LFS upload failed:   0% (0/1), 0 B | 0 B/s                                                                    
  (missing) LFS-POINTERS/dummy-file.txt (4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393)
hint: Your push was rejected due to missing or corrupt local objects.
hint: You can disable this check with: `git config lfs.allowincompletepush true`
Uploading LFS objects:   0% (0/1), 0 B | 0 B/s, done.
Error: exit status 2
error: failed to push some refs to 'https://github.com/calypr/monorepo.git'

The user can then backout changes to the repo, correct the data and proceed normally.

Copilot

Pull request overview

This PR refactors the DRS object preparation workflow by moving it from transfer-time to a pre-push hook, improving predictability and reducing transfer-side overhead. The key changes shift LFS candidate discovery to use git lfs push --dry-run for more accurate file selection, and install a pre-push hook during initialization to orchestrate the workflow.

Adds git drs prepush command to prepare DRS objects before invoking Git LFS pre-push
Implements dry-run-based LFS file discovery with remote/ref resolution and pointer file safeguards
Installs pre-push hook during git drs init for consistent workflow execution

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
cmd/prepush/main.go	New pre-push hook command that buffers stdin, prepares DRS objects, and delegates to git lfs pre-push
cmd/initialize/main.go	Adds pre-push hook installation logic with existing hook preservation
drsmap/drs_map.go	Implements dry-run-based LFS discovery with ResolveRemoteAndRef, RunLfsPushDryRun, and pointer file detection
drslog/logger.go	Adds PID prefix and fixes call depth for accurate caller location in logs
cmd/transfer/main.go	Removes UpdateDrsObjects call as it's now handled by pre-push hook
cmd/root.go	Registers prepush command in CLI
config/config.go	Improves error message clarity
docs/developer-guide.md	Documents new pre-push workflow in developer guide
docs/commands.md	Documents prepush command and hook installation
tests/monorepos/list-indexd.sh	New utility script for listing Indexd records from Kubernetes pod
tests/monorepos/run-test.sh	Moves set -x earlier and makes remote/branch explicit in git push commands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

drslog/logger.go

Copilot · 2026-01-08T19:20:53Z

drsmap/drs_map.go

+	out, err := RunLfsPushDryRun(ctx, repoDir, spec, logger)
+	if err != nil {
+		return nil, err
 	}

-	// create a map of LFS file info
 	lfsFileMap := make(map[string]LfsFileInfo)


If git lfs push --dry-run returns no output (empty string), the function will return an empty map without any indication that no files were found. This could be confusing when debugging - was there an issue, or are there genuinely no LFS files to push? Consider logging a message when the dry-run output is empty to help distinguish between these cases, for example: "No LFS files to push (dry-run returned no output)".

@copilot open a new pull request to apply changes based on this feedback

cmd/initialize/main.go

drsmap/drs_map.go

cmd/prepush/main.go

tests/monorepos/list-indexd.sh

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

bwalsh · 2026-01-09T17:16:14Z

Avoid duplicate indexd hash lookups during registration

Context

Registering a file currently checks for existing indexd records and then asks for a
download URL to determine whether the file is already available. The download URL
path invokes another hash lookup, resulting in duplicate indexd calls and duplicate
log lines for the same OID. This adds latency and noise without improving behavior.

Old

sequenceDiagram
participant Client
participant Indexd
participant DRS
 
Client->>Indexd: GET /index/index?hash=sha256:{oid}
Indexd-->>Client: ListRecords
Client->>DRS: GetDownloadURL(oid)
DRS->>Indexd: GET /index/index?hash=sha256:{oid}
Indexd-->>DRS: ListRecords
DRS-->>Client: AccessURL

Decision

Reuse the results of the initial GetObjectByHash call in RegisterFile when
checking downloadability. Move the download URL logic into a helper that accepts
pre-fetched records so the registration flow does not need to issue a second hash
query.

New

sequenceDiagram
participant Client
participant Indexd
participant DRS
 
Client->>Indexd: GET /index/index?hash=sha256:{oid}
Indexd-->>Client: ListRecords
Client->>DRS: getDownloadURLFromRecords(oid, records)
DRS-->>Client: AccessURL

Alternatives Considered

We considered a solution to pass the already-retrieved records to GetDownloadURL() instead of having it query indexd again. ie:

// Modify GetDownloadURL() to accept optional records
// Add an overloaded version or modify GetDownloadURL() to accept pre-fetched records
func (cl *IndexDClient) GetDownloadURL(oid string, records []drs.DRSObject) (*drs.AccessURL, error) {
  // If records is nil, it will query indexd.  Otherwise, it uses the provided records.
   ...
}

While this is cleaner and "more natural", this would break the interface and require changes to:

The interface definition itself
All implementations of DRSClient
All callers of GetDownloadURL()

So, a better solution was to create an internal helper method that doesn't change the public interface. See:

func (cl *IndexDClient) getDownloadURLFromRecords(oid string, records []drs.DRSObject) (*drs.AccessURL, error)

Consequences

Registration performs a single hash lookup per OID in the common path.
Logging is less noisy because redundant "Found ... indexd record(s)" lines are
avoided.
GetDownloadURL behavior remains unchanged for external callers.

Manual testing

From tests/monorepos/fixtures, confirm only called once by matching Found N indexd record(s) matching the hash

$ grep sub-directory-3/file-0100 .drs/git-drs.log  | grep TARGET-ALL-P2 | grep Found | wc -l
       1
$ grep sub-directory-3/file-0100 .drs/git-drs.log  | grep TCGA-GBM | grep Found | wc -l
       1

bwalsh · 2026-01-09T17:24:40Z

Indexd mock server instrumentation for hash lookup tests

Context

The test suite needs to verify that RegisterFile performs a single hash lookup
when checking downloadability. The existing mock indexd server in
client/indexd/tests/mock_servers_test.go already simulates indexd endpoints and
DRS object/access responses, but it did not record how many times the hash query
endpoint was invoked. Without that counter, tests could not reliably assert that
duplicate lookups were removed.

Decision

Instrument the mock indexd server to track hash query calls and to serve an HTTP
endpoint that can be used as a signed URL target during tests:

Add hashQueryCount and a HashQueryCount() accessor to record how many times
/index/index?hash=... is requested.
Add signedURLBase and a /signed/ handler to provide a stable HTTP target
for utils.CanDownloadFile when the download URL is checked.

These changes allow tests to assert the single-lookup behavior without relying on
external services.

sequenceDiagram
participant Test
participant IndexdMock
participant Client
 
Test->>Client: RegisterFile(oid)
Client->>IndexdMock: GET /index/index?hash=sha256:{oid}
IndexdMock-->>Client: ListRecords (hashQueryCount++)
Client->>IndexdMock: GET /ga4gh/drs/v1/objects/{id}/access/{accessId}
IndexdMock-->>Client: AccessURL (/signed/...)
Client->>IndexdMock: GET /signed/... (CanDownloadFile)
IndexdMock-->>Client: 200 OK
Test->>IndexdMock: HashQueryCount()

Consequences

Tests can validate that RegisterFile reuses the original hash lookup results.
The mock server remains self-contained, including an HTTP target for signed URL
checks.

#!/bin/bash
set -e
set -x  # Print each command as it's executed

# Set repo name and remote URL
REPO_NAME="git-drs-e2e-test-3"
GIT_USER="cbds"
# REMOTE_URL="https://source.ohsu.edu/$GIT_USER/$REPO_NAME"
REMOTE_URL="git@source.ohsu.edu:$GIT_USER/$REPO_NAME.git"

# Clean up if rerunning (don't fail if not removable)
rm -rf "$REPO_NAME" || true

# Create directory and initialize git
mkdir "$REPO_NAME"
cd "$REPO_NAME"


# Step 1: Initialize Repository
git init
git drs remote add gen3 local --url https://caliper-local.ohsu.edu/ --cred ~/.gen3/credentials-local.json --project cbds-git_drs_test --bucket cbds
git drs init

# set branch / add remote
git branch -M main
git remote add origin "$REMOTE_URL"

git lfs track "*.greeting"
git add .gitattributes

# Step 2: Create and Commit Initial Files
mkdir -p data/A data/B data/C

DATE="hello $(date)"
echo $DATE > data/A/simple.greeting
echo $DATE > data/B/simple.greeting
echo $DATE > data/C/simple.greeting

git add data/
git add .drs/config.yaml
git commit -m "Initial commit: Add .greeting files with 'hello'"

# Prompt user for remote if not set
git push -f
forge publish $GH_PAT

# check that list works
FORGE_UID=$(forge list | sed -n '2p' | awk '{print $2}')
if [ -z "$FORGE_UID" ]; then
  echo "Error: No UID found in forge list"
  exit 1
fi

# check status and output works
sleep 5
forge status "$FORGE_UID" > status.log 2>&1
grep "Status" status.log || { echo "Error: forge status failed"; exit 1; }
forge output "$FORGE_UID" > output.log 2>&1
grep "Logs" output.log || { echo "Error: forge output failed"; exit 1; }


# Keep polling forge status until either Failed or Completed
while true; do
  STATUS=$(forge status "$FORGE_UID" | grep "Status" | awk '{print $6}')
  echo "Current status: $STATUS"
  if [ "$STATUS" == "Completed" ]; then
    echo "Forge job completed successfully."
    break
  elif [ "$STATUS" == "Failed" ]; then
    echo "Forge job failed."
    exit 1
  else
    echo "Forge job still in progress. Waiting for 10 seconds before checking again..."
    sleep 10
  fi
done


# # Step 3: clone and pull files
git clone "$REMOTE_URL"
cd "$REPO_NAME"
git drs init
git lfs pull

quinnwai · 2026-01-09T14:58:22Z

docs/commands.md


 These commands are called automatically by Git hooks:

 - `git drs precommit`: Process staged files during commit


To your point in #124, could we remove git drs precommit entirely from docs / commands? Not being used anywhere and would just cause user confusion.

@copilot write an issue

tests/monorepos/run-test.sh

quinnwai · 2026-01-09T15:16:00Z

cmd/initialize/main.go

+		if !strings.HasSuffix(updated, "\n") {
+			updated += "\n"
+		}
+		updated += "\n# git-drs pre-push hook\n" + hookBody


when git drs init is called on an existing Git DRS repo, this lfs pre-push and drs pre-push get placed the wrong way around in the git hook. For instance, after appending:

#!/bin/sh command -v git-lfs >/dev/null 2>&1 || { printf >&2 "\n%s\n\n" "This repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting the 'pre-push' file in the hooks directory (set by 'core.hookspath'; usually '.git/hooks')."; exit 2; } git lfs pre-push "$@" # git-drs pre-push hook remote="$1" if [ -n "$remote" ]; then git drs prepush "$remote" else git drs prepush fi

Not sure if you have a migration strategy but I imagine this might become a problem.

Great catch thanks.

when git drs init is called on an existing Git DRS repo,

Can you document how to re-create?

sure so TLDR is git drs init using an older version (0.5.0) and then git drs init using a newer version.

To curl older version:

/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/calypr/git-drs/refs/heads/fix/install-error-macos/install.sh)" -- 0.5.0

Lmk if that works

quinnwai · 2026-01-09T15:18:41Z

cmd/prepush/main.go

+	Long:  "Pre-push hook that updates DRS objects before transfer",
+	Args:  cobra.RangeArgs(0, 1),
+	RunE: func(cmd *cobra.Command, args []string) error {
+		//myLogger := drslog.GetLogger()


remove comment?

Suggested change

//myLogger := drslog.GetLogger()

drsmap/drs_map.go

tests/monorepos/list-indexd.sh

quinnwai · 2026-01-09T17:21:14Z

tests/integration/calypr/end_to_end_test.go

 	}

+	// create a drs logger and pass it to GetAllLfsFiles
+	logger := &drslog.Logger{}


Suggested change

logger := &drslog.Logger{}

logger, err := drslog.NewLogger("", true)

if err != nil {

t.Fatalf("Failed to create logger: %v", err)

}

defer drslog.Close()

nil pointer error when testing...

Could you check that the e2e test passes on your end? Still running into errors

Error

$go test tests/integration/calypr/end_to_end_test.go [52744] 2026/01/09 09:16:28 drs_map.go:39: running command: [git symbolic-ref -q --short HEAD] [52744] 2026/01/09 09:16:28 drs_map.go:39: running command: [git for-each-ref --format=%(upstream:short) refs/heads/main] [52744] 2026/01/09 09:16:28 drs_map.go:117: running command: [git lfs push --dry-run origin HEAD] --- FAIL: TestEndToEndGitDRSWorkflow (21.23s) end_to_end_test.go:48: Temporary directory: /var/folders/nq/88_4pk_s25z4g3g52gvm5b88px118k/T/git-drs-e2e-2383170322 end_to_end_test.go:106: Running CMD: calypr_admin collaborators add wongq@ohsu.edu /programs/test/projects/hao7d2fu --project_id test-hao7d2fu --profile calypr-dev -w -a approved: /end_test.go:136: calypr_admin collaborators add: - policy_id: programs.test.projects.hao7d2fu_reader request_id: a5b983db-904f-4209-96b0-fbcf977b9c8c status: SIGNED username: wongq@ohsu.edu - policy_id: programs.test.projects.hao7d2fu_writer request_id: 8cdc774d-6a3c-4c18-8678-f138e26cbceb status: SIGNED username: wongq@ohsu.edu msg: OK end_to_end_test.go:149: git-drs add remote output: 2026/01/09 09:16:27 logger.go:77: .gitignore has been updated and staged 2026/01/09 09:16:27 logger.go:77: Git DRS initialized 2026/01/09 09:16:27 logger.go:71: Using 4 concurrent transfers end_to_end_test.go:157: git-drs add remote output: 2026/01/09 09:16:27 logger.go:71: Remote added/updated: calypr-dev → https://calypr-dev.ohsu.edu (project: test-hao7d2fu, bucket: cbds) 2026/01/09 09:16:27 logger.go:71: Gen3 profile 'calypr-dev' configured and token refreshed successfully end_to_end_test.go:172: .drs/config.yaml contents: default_remote: calypr-dev remotes: calypr-dev: gen3: endpoint: https://calypr-dev.ohsu.edu project_id: test-hao7d2fu bucket: cbds end_to_end_test.go:205: Remote URL: https://source.ohsu.edu/CBDS/test-hao7d2fu.git end_to_end_test.go:234: Failed to get LFS files: git lfs push --dry-run failed: Invalid remote name "origin": invalid remote name: "/private/var/folders/nq/88_4pk_s25z4g3g52gvm5b88px118k/T/git-drs-e2e-2383170322/test-hao7d2fu/origin" FAIL FAIL command-line-arguments 21.867s FAIL

Repro

See tests/README.md on how to setup env vars etc

go test -v tests/integration/calypr/end_to_end_test. go

I haven't had the chance to confirm - the end to end test is failing because of logging?

@quinnwai confirmed I can reproduce this. thanks

quinnwai · 2026-01-09T17:25:53Z

cmd/prepush/main.go

+		}
+
+		// Build and run: git lfs pre-push <args...>
+		cmdArgs := append([]string{"lfs", "pre-push"}, args...)


Why are we using lfs pre-push as opposed to lfs status?

See your catch above "when git drs init is called on an existing Git DRS repo, this lfs pre-push and drs pre-push get placed the wrong way around in the git hook. "

When that is fixed, this goes away.

I think I had a different question, moreso why we use lfs pre-push to get the set of files required for commit as opposed to lfs status which does the same and to my limited testing seems a bit faster. I think this is more a performance question when do via test-monorepo testing etc tho. if lfs pre-push isn't significantly slow and still faster that our prev implementation then I defer to you on this

Copilot · 2026-01-09T17:57:34Z

@bwalsh I've opened a new pull request, #134, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-09T18:00:48Z

@bwalsh I've opened a new pull request, #135, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-09T18:03:06Z

@bwalsh I've opened a new pull request, #136, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Quinn Wai Wong <54592956+quinnwai@users.noreply.github.com>

matthewpeterkort · 2026-01-08T19:01:42Z

drsmap/drs_map.go

-func GetAllLfsFiles() (map[string]LfsFileInfo, error) {
-	// get all LFS files' info using json
-	cmd := exec.Command("git", "lfs", "ls-files", "--json")
+func getDefaultRemote() (string, error) {


this func doesn't appear to be called anywhere

+1, good call forgot to add a comment on this

tests/monorepos/run-test.sh

quinnwai · 2026-01-09T20:25:42Z

client/indexd/indexd_client.go

 	isDownloadable := true
 	cl.Logger.Printf("checking if %s file is downloadable", oid)
-	signedUrl, err := cl.GetDownloadURL(oid)
+	signedUrl, err := cl.getDownloadURLFromRecords(oid, recordsForDownload)


Makes sense from reading it but for some reason still running into a weird git lfs pre-push error. You can reproduce by rerunning the script I attached here

Logs

[61592] 2026/01/09 12:22:38 main.go:155: ~~~~~~~~~~~~~ START: drs transfer ~~~~~~~~~~~~~ [61592] 2026/01/09 12:22:38 main.go:193: Using 8 concurrent workers (from Git LFS) [61592] 2026/01/09 12:22:38 main.go:245: Transfer operation: upload [61578] 2026/01/09 12:22:38 main.go:274: Current command: {"event":"upload","oid":"f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767","size":34,"path":"/Users/wongq/data/calypr/git-drs/calypr-dev/git-drs-e2e-test-3/.git/lfs/objects/f5/cc/f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767","action":null} [61578] 2026/01/09 12:22:38 main.go:127: Worker 2: Uploading file OID f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767 [61578] 2026/01/09 12:22:38 indexd_client.go:275: register file started for oid: f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767 [61578] 2026/01/09 12:22:38 indexd_client.go:658: Querying indexd at https://calypr-dev.ohsu.edu/index/index?hash=sha256:f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767 [61578] 2026/01/09 12:22:38 indexd_client.go:664: Looking for files with hash sha256:f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767 [61578] 2026/01/09 12:22:39 indexd_client.go:691: Found 0 indexd record(s) matching the hash {[] [] 0 0 100 [] [] [] { f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767 } map[] } [61578] 2026/01/09 12:22:39 indexd_client.go:298: creating record: no existing indexd record for this project [61578] 2026/01/09 12:22:39 indexd_client.go:569: retrieved IndexdObj: {"did":"fc8efc22-429c-5ec5-a77f-ecc28ab315d5","file_name":"data/A/simple.greeting","urls":["s3://cbds/fc8efc22-429c-5ec5-a77f-ecc28ab315d5/f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767"],"size":34,"authz":["/programs/cbds/projects/git_drs_test"],"hashes":{"sha256":"f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767"},"form":"object"} [61578] 2026/01/09 12:22:39 indexd_client.go:590: POST request created for indexd: https://calypr-dev.ohsu.edu/index/index [61578] 2026/01/09 12:22:39 indexd_client.go:604: POST successful: 200 OK [61578] 2026/01/09 12:22:40 indexd_client.go:611: GET for DRS ID successful: fc8efc22-429c-5ec5-a77f-ecc28ab315d5 [61578] 2026/01/09 12:22:40 indexd_client.go:351: checking if f5cc729662804a6deb0ca5caed1f65813a62f93caff12a526fd8ad854ee21767 file is downloadable [61584] 2026/01/09 12:22:40 main.go:274: Current command: {"event":"terminate"} [61586] 2026/01/09 12:22:40 main.go:274: Current command: {"event":"terminate"} [61586] 2026/01/09 12:22:40 main.go:278: Received TERMINATE signal [61586] 2026/01/09 12:22:40 main.go:304: ~~~~~~~~~~~~~ COMPLETED: custom transfer ~~~~~~~~~~~~~ [61588] 2026/01/09 12:22:40 main.go:274: Current command: {"event":"terminate"} [61588] 2026/01/09 12:22:40 main.go:278: Received TERMINATE signal [61584] 2026/01/09 12:22:40 main.go:278: Received TERMINATE signal [61588] 2026/01/09 12:22:40 main.go:304: ~~~~~~~~~~~~~ COMPLETED: custom transfer ~~~~~~~~~~~~~ [61592] 2026/01/09 12:22:40 main.go:274: Current command: {"event":"terminate"} [61592] 2026/01/09 12:22:40 main.go:278: Received TERMINATE signal [61592] 2026/01/09 12:22:40 main.go:304: ~~~~~~~~~~~~~ COMPLETED: custom transfer ~~~~~~~~~~~~~ [61590] 2026/01/09 12:22:40 main.go:274: Current command: {"event":"terminate"} [61590] 2026/01/09 12:22:40 main.go:278: Received TERMINATE signal [61584] 2026/01/09 12:22:40 main.go:304: ~~~~~~~~~~~~~ COMPLETED: custom transfer ~~~~~~~~~~~~~ [61590] 2026/01/09 12:22:40 main.go:304: ~~~~~~~~~~~~~ COMPLETED: custom transfer ~~~~~~~~~~~~~ [61580] 2026/01/09 12:22:40 main.go:274: Current command: {"event":"terminate"} [61582] 2026/01/09 12:22:40 main.go:274: Current command: {"event":"terminate"} [61582] 2026/01/09 12:22:40 main.go:278: Received TERMINATE signal [61580] 2026/01/09 12:22:40 main.go:278: Received TERMINATE signal [61580] 2026/01/09 12:22:40 main.go:304: ~~~~~~~~~~~~~ COMPLETED: custom transfer ~~~~~~~~~~~~~ [61582] 2026/01/09 12:22:40 main.go:304: ~~~~~~~~~~~~~ COMPLETED: custom transfer ~~~~~~~~~~~~~ [61524] 2026/01/09 12:22:40 main.go:103: git lfs pre-push failed: exit status 2

* push origin main * fix #132

* Doing a token request if it is unable to parse the experation date. Also reverting the logging to fix debug output issue * adds mutex * refactored logger

bwalsh added 5 commits January 8, 2026 09:42

push origin main

fe8d44c

improves logger #126

e92a713

adds git lfs push --dry-run; #124

a7840cc

adds utility to list ids in db

c011766

move UpdateDrsObjects to pre-push; #124

7eca2be

Copilot AI review requested due to automatic review settings January 8, 2026 18:19

Copilot started reviewing on behalf of bwalsh January 8, 2026 18:20 View session

bwalsh requested review from Copilot, kellrott, matthewpeterkort and quinnwai and removed request for Copilot January 8, 2026 18:21

Copilot started reviewing on behalf of bwalsh January 8, 2026 19:15 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

bwalsh and others added 4 commits January 8, 2026 13:11

Apply suggestions from code review

1f88eb1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adds logger for GetAllLfsFiles

34cd060

pr review; pass param

0a17791

Validate OIDdrsmap

20f3a9e

This was referenced Jan 8, 2026

Add logging when git lfs push --dry-run returns empty output #128

Merged

Confirm hook appending comment already addresses review feedback #129

Closed

calypr deleted a comment from Copilot AI Jan 8, 2026

Add logging when git lfs push --dry-run returns empty output (#128)

75b253f

calypr deleted a comment from Copilot AI Jan 9, 2026

fix #125

b41dbe4

quinnwai requested changes Jan 9, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 9, 2026

Fix pre-push hook to always call git lfs pre-push when DRS config incomplete #134

Closed

Copilot AI mentioned this pull request Jan 9, 2026

Provide issue description for removing unused git drs precommit command #135

Closed

Copilot AI mentioned this pull request Jan 9, 2026

Respond to review comment on unused getDefaultRemote function #136

Closed

bwalsh and others added 2 commits January 9, 2026 10:04

Apply suggestions from code review

1983ed6

Co-authored-by: Quinn Wai Wong <54592956+quinnwai@users.noreply.github.com>

fix: dropped second optional argument remote-url

bb461e2

Co-authored-by: Quinn Wai Wong <54592956+quinnwai@users.noreply.github.com>

matthewpeterkort reviewed Jan 9, 2026

View reviewed changes

quinnwai reviewed Jan 9, 2026

View reviewed changes

fix: panic nil pointer;tighten checks

ae1b655

quinnwai mentioned this pull request Jan 9, 2026

Tradeoff between Testability + Ease of Implementation #139

Open

bwalsh and others added 19 commits January 10, 2026 09:34

capture arguments

fcba701

extract local branches

0a4aee1

#139 improve hook install

4f4cb84

#142

bbe3dfc

log lfs command responses

5b1bb2f

gitRemoteName, gitRemoteLocation passed from pre-push

d197b29

adds ad-hoc script tests

a155e7c

bug/broken-pipe (#133)

e1d9f5b

* push origin main * fix #132

verbose EOF logging

5ce5263

fix dry-run args

2babf0f

fix merge

1f371f8

#143 bug retry http calls

8fd1a16

Adds unit tests (#131)

2eacd9a

refactor unit tests

528b7ca

error if authorization not found

6c34ccb

removed re-query

dd46007

log record if no auth

0aa6770

latest data-client

2e617da

[WIP] Fixing drs list (#146)

4a33c47

* Doing a token request if it is unable to parse the experation date. Also reverting the logging to fix debug output issue * adds mutex * refactored logger


		These commands are called automatically by Git hooks:

		- `git drs precommit`: Process staged files during commit

-	logger := &drslog.Logger{}
+	logger, err := drslog.NewLogger("", true)
+	if err != nil {
+		t.Fatalf("Failed to create logger: %v", err)
+	}
+	defer drslog.Close()

Feature/improve on push filter #127

Are you sure you want to change the base?

Feature/improve on push filter #127

Conversation

bwalsh commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Architecture Changes

old

new

Links to Issues

Reviewer Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bwalsh commented Jan 9, 2026

Avoid duplicate indexd hash lookups during registration

Context

Old

Decision

New

Alternatives Considered

Consequences

Related

Manual testing

Uh oh!

bwalsh commented Jan 9, 2026

Indexd mock server instrumentation for hash lookup tests

Context

Decision

Consequences

Related

Uh oh!

quinnwai left a comment

Choose a reason for hiding this comment

Overall

Example E2E Testing Script

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

bwalsh commented Jan 8, 2026 •

edited

Loading