Skip to content

Conversation

Copy link

Copilot AI commented Jan 9, 2026

The pre-push hook was returning early when GetRemoteClient failed, which skipped both DRS preparation and git lfs pre-push. This broke LFS file transfers when DRS configuration was incomplete (e.g., "push was called before drs config complete").

Changes

  • Extracted DRS preparation to prepareDrsObjects(): Isolated error-prone logic into a function that returns early on failures without blocking the main push flow
  • Changed DRS errors from fatal to warnings: All DRS-related failures (GetDefaultRemote, GetRemoteClient, UpdateDrsObjects) now log warnings and continue instead of returning early
  • Ensured git lfs pre-push always executes: Main hook flow now unconditionally calls git lfs pre-push after attempting DRS preparation
  • Added support for all DRS client types: Removed hard failure on non-IndexDClient types; now handles IndexDClient and AnvilClient appropriately

Behavior

When DRS config is incomplete or operations fail:

Warning. Skipping DRS preparation. Error getting remote client: <error>
# DRS preparation skipped
# git lfs pre-push proceeds normally
# LFS files transfer successfully

Users can now push LFS files regardless of DRS configuration state. DRS issues are surfaced as warnings to stderr and logs, but don't block Git operations.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 4 commits January 9, 2026 18:05
…omplete

Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Copilot AI changed the title [WIP] Improve clarity and re-test for push filter Fix pre-push hook to always call git lfs pre-push when DRS config incomplete Jan 9, 2026
Copilot AI requested a review from bwalsh January 9, 2026 18:14
@bwalsh bwalsh closed this Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants