refactor(cli): better prompt dependencies #153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c3b08da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report for ./apps/cli
File CoverageNo changed files found. |
tuler
reviewed
Feb 25, 2025
Member
tuler
left a comment
tuler
left a comment
There was a problem hiding this comment.
I see several are depending on service_started instead of service_healthy. Is that because they don't have the proper health check?
endersonmaia
force-pushed
the
refactor/better-prompt-dependency
branch
from
3170bea to
c3b08da
Compare
4 tasks
Contributor
Author
|
prompt is being deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the dependency management of the
promptservice in various Docker Compose configurations. The most important changes are the addition ofdepends_onconditions to ensure that thepromptservice starts only after its dependencies are in the appropriate state.Dependency management improvements:
.changeset/lazy-feet-explode.md: Added a changeset file indicating a patch update for@cartesi/cliwith a note on better prompt service dependency.apps/cli/src/node/docker-compose-anvil.yaml: Addeddepends_onconditions foranvilanddapp_deployerservices to ensure thepromptservice starts only after these services are healthy or completed successfully.apps/cli/src/node/docker-compose-bundler.yaml: Addeddepends_oncondition for thealtoservice to ensure thepromptservice starts only after thealtoservice has started.apps/cli/src/node/docker-compose-explorer.yaml: Addeddepends_oncondition for theexplorerservice to ensure thepromptservice starts only after theexplorerservice has started.apps/cli/src/node/docker-compose-paymaster.yaml: Addeddepends_oncondition for themock-verifying-paymasterservice to ensure thepromptservice starts only after themock-verifying-paymasterservice has started.apps/cli/src/node/docker-compose-validator.yaml: Addeddepends_oncondition for thevalidatorservice to ensure thepromptservice starts only after thevalidatorservice is healthy.