-
Notifications
You must be signed in to change notification settings - Fork 12
Replacement of prompt service with custom code #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e778033 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report for ./apps/cli
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
Total startup time in my machine with |
endersonmaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing healthchecks for services you described and defined the dependency.
b295744 to
48ddef2
Compare
endersonmaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest normalizing healthcheck parameters between services (interval, start_time, etc.)
Done. |
8559406 to
294dd4e
Compare
4439190 to
caf7a2f
Compare
caf7a2f to
c2a395d
Compare
endersonmaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--verbose is not working, but I'll consider this PR approved, and we can tackle this --verbose behavior on another PR
b999336 to
24ad87e
Compare
While working on the startup feedback, I ended up redoing a lot of the work that was done at PRs #177 and #153
So this PR includes some of those changes, but also the new startup feedback.
Please check my individual commits on this PR, and compare them to the ones at #177
The startup feedback works by creating a listr2 of tasks where each task is a polling of
docker compose ps <service>for the healthy status of a service. For each service there is a service name, but also ahealthySemaphorewhich is the name of the service that indicates healthy status.For example, the
graphqlis a service, but we need to wait for theproxyservice to be healthy to report access tographql, as it is proxied through it.I only implemented healthy status checks, which means that every service that is part of the startup feedback will now require a health check configuration. We are still missing health check config for the following services: