-
Notifications
You must be signed in to change notification settings - Fork 12
Improve time to start #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix send subcommands
move all commands to .addCommand instead of .command
|
Coverage Report for ./apps/cli
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
My idea for the replacement of the prompt was to write a typescript library that monitors the |
Please, open an issue to track this. |
86691a1 to
1c1db1d
Compare
| image: debian:bookworm-slim | ||
| environment: | ||
| PROMPT_TXT_01_ANVIL: "Anvil running at http://localhost:8545" | ||
| volumes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why db volume in anvil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it's the container we have always running that uses the cartesi/sdk image which has the initialized database
ugly, I know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having another container with a sleep infinity looked worse for me
do you have any other idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extend postgres image itself with the db?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean, make the cartesi/sdk based on postgres?
or maintain another container image cartesi/postgres ?
b6ab38c to
1d1dd72
Compare
1d1dd72 to
be6865d
Compare
caf7a2f to
c2a395d
Compare
|
Replaced by #179 |
TL;DR
With first 2 items, already reduced from ~30s to ~9.5s on my environment.
cartesi statusand on another PR?)This pull request includes significant changes to the
apps/clidirectory, focusing on removing thepromptservice from various Docker Compose files and adjusting health check configurations.Removal of
promptservice:apps/cli/src/commands/rollups/start.ts: Removed thedocker-compose-prompt.yamlreference from the list of Docker Compose files.apps/cli/src/compose/rollups/docker-compose-anvil.yaml: Removed thepromptservice configuration.apps/cli/src/compose/rollups/docker-compose-bundler.yaml: Removed thepromptservice configuration.apps/cli/src/compose/rollups/docker-compose-database.yaml: Removed thepromptservice configuration.apps/cli/src/compose/rollups/docker-compose-espresso.yaml: Removed thepromptservice configuration.apps/cli/src/compose/rollups/docker-compose-explorer.yaml: Removed thepromptservice configuration.apps/cli/src/compose/rollups/docker-compose-graphql.yaml: Removed thepromptservice configuration.apps/cli/src/compose/rollups/docker-compose-node.yaml: Removed thepromptservice configuration.apps/cli/src/compose/rollups/docker-compose-paymaster.yaml: Removed thepromptservice configuration.apps/cli/src/compose/rollups/docker-compose-prompt.yaml: Removed the entirepromptservice file.apps/cli/src/compose/rollups/docker-compose-proxy.yaml: Removed thepromptservice dependency.Health check configuration adjustments:
apps/cli/src/compose/rollups/docker-compose-anvil.yaml: Updated health check intervals, timeouts, and retries.apps/cli/src/compose/rollups/docker-compose-database.yaml: Updated health check intervals, timeouts, and retries.apps/cli/src/compose/rollups/docker-compose-node.yaml: Updated health check intervals, timeouts, and retries.apps/cli/src/compose/rollups/docker-compose-proxy.yaml: Updated health check intervals, timeouts, and retries.