Skip to content

Conversation

@nimashariatian
Copy link

hi guys,
this PR fixes an issue for Rails 5.2 regarding ActionView::Tags::Base

the following code:

option_tags_options = {
selected: @options.fetch(:selected) { value(@object) },
disabled: @options[:disabled]
}

fails as value isn't called with any arguments from rails tag methods, eg:

https://github.com/rails/rails/blob/659c516bef2781cc66865fc78ed5dce682566d26/actionview/lib/action_view/helpers/tags/base.rb#L53

object is available here, so shouldn't need to be passed as an arg:

https://github.com/rails/rails/blob/659c516bef2781cc66865fc78ed5dce682566d26/actionview/lib/action_view/helpers/tags/base.rb#L10

@nimashariatian
Copy link
Author

@cllns any feedback on this PR?

@nimashariatian
Copy link
Author

let me know if you would like this to be done in another branch, but considering how it's such a minor update, i did it on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant