Skip to content

Fix broken value method call for Rails 5.2 regarding ActionView Tags #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nimashariatian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix broken value method call for Rails 5.2 regarding ActionView Tags #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/subdivision_select/tag_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,19 @@ module SubdivisionSelect
#class CountryNotFoundError < StandardError;end
module TagHelper
def subdivision_option_tags
# In Rails 5.2+, `value` accepts no arguments and must also be called
# called with parens to avoid the local variable of the same name
# https://github.com/rails/rails/pull/29791
selected_option = @options.fetch(:selected) do
if self.method(:value).arity == 0
value
else
value(@object)
end
end

option_tags_options = {
selected: @options.fetch(:selected) { value(@object) },
selected: selected_option,
disabled: @options[:disabled]
}

Expand Down