Skip to content

Avoid invalid expressions like if(ON AND) when a variable is empty #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codereader merged 1 commit into from
Jan 24, 2026
Merged

Avoid invalid expressions like if(ON AND) when a variable is empty #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions install.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ install(TARGETS radiantcore script sound
LIBRARY DESTINATION ${PKGLIBDIR}/modules)

# Install Dark Mod plugins
if (${ENABLE_DM_PLUGINS})
if (ENABLE_DM_PLUGINS)
install(TARGETS dm_stimresponse dm_objectives dm_difficulty dm_editing
dm_gui dm_gameconnection dm_conversation
LIBRARY DESTINATION ${PKGLIBDIR}/plugins)
endif()

if (${ENABLE_GIT_PLUGIN} AND ${LIBGIT_FOUND})
if (ENABLE_GIT_PLUGIN AND LIBGIT_FOUND)
install(TARGETS vcs LIBRARY DESTINATION ${PKGLIBDIR}/plugins)
endif()

Expand Down Expand Up @@ -42,7 +42,7 @@ install(FILES ${PROJECT_SOURCE_DIR}/install/net.darkradiant.DarkRadiant.metainfo
DESTINATION ${CMAKE_INSTALL_DATADIR}/metainfo)

# Install locale data
if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.14")
if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.14")
# CMake 3.14 and above support TYPE LOCALE, they deduct DESTINATION themselves
install(DIRECTORY install/i18n/de TYPE LOCALE FILES_MATCHING PATTERN "*.mo")
else()
Expand All @@ -52,4 +52,4 @@ endif()

# Install scripts
install(DIRECTORY install/scripts DESTINATION ${PKGDATADIR}
FILES_MATCHING PATTERN "*.py")
FILES_MATCHING PATTERN "*.py")