Skip to content

Conversation

@raithedavion
Copy link
Contributor

@raithedavion raithedavion commented Nov 11, 2025

Description

Please provide a clear and concise description of your changes.
Explain what your PR does and why it's necessary.

I had a use case for using this in conjunction with a WYSIWYG editor, and I needed specific css classes that correspond to the editor to be mapped to specific styles in a template word document. So I made the required changes to the module and so far my local changes work very well.

Issue Reference

Link to the issue this PR addresses, if applicable.
Example: Fixes #123

Checklist Before Requesting a Review

  • I have performed a self-review of my code.
  • My code follows the project's coding style and guidelines.
  • I have run tests and verified that all existing and new tests pass.
  • I have added new tests to cover my changes.

@raithedavion raithedavion changed the base branch from main to release/1.1.1 November 11, 2025 17:31
@dfop02 dfop02 self-requested a review November 12, 2025 11:54
@raithedavion
Copy link
Contributor Author

Requested changes made. Let me know if you want me to pull down your current "HISTORY" or if you want to manually merge that file.

@dfop02
Copy link
Owner

dfop02 commented Nov 14, 2025

Thanks @raithedavion , I'll review all again this weekend :)

@dfop02 dfop02 added documentation Improvements or additions to documentation New Feature New feature or request labels Nov 16, 2025
@dfop02
Copy link
Owner

dfop02 commented Nov 16, 2025

Hi @raithedavion !
I finally had time to review everything more carefully. I went through each part slowly and thoroughly. Thanks again for all your effort in helping make this project even better!

Copy link
Owner

@dfop02 dfop02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a friendly reminder to review the updates on your PR. I left a few comments and also pushed the “html-comments” PR, so you’ll need to rebase and resolve the conflicts when you get a chance. Thanks!

@raithedavion
Copy link
Contributor Author

Planning on getting it this weekend. Unfortunately had other priorities this week :D

@raithedavion
Copy link
Contributor Author

Changes implemented.

@dfop02
Copy link
Owner

dfop02 commented Nov 25, 2025

@raithedavion I could you remove all the lint changes you introduced, focusing just on you changes? Recently merged a new feature and it introduced some conflicts in a few files. Could you please merge the latest release/1.1.1 into your branch and resolve the conflicts?

Also, please be aware that PR #48 conflicts with some of your commits. I’m giving priority to reviewing and merging whichever PR addresses all changes and fixes first. You’re both doing a great job, and I’m looking forward to merging your contributions to help the project grow.

@dfop02
Copy link
Owner

dfop02 commented Nov 26, 2025

@raithedavion Release 1.1.1 is officially out! 🎉
I created a new release branch release/1.1.2 for the next features, I know resolving the conflicts may have taken some time, so no worries. Some of the features you’re working on might already be covered by this release, please double-check, as it could address part of what you need.

Also, please remove the lint adjustments for now to avoid additional conflicts. I was following the flake8 rules, but it looks like the test workflow isn’t running correctly and needs to be fixed later. I’m also considering switching to another linter, so if you have any suggestions, I’m open to new ideas.

Let me know if you need any help or adjustments!

@raithedavion raithedavion force-pushed the class-map-tag-override branch from eb45941 to df4bf85 Compare December 1, 2025 21:09
Required changes + rebase to release/1.1.2.
@raithedavion
Copy link
Contributor Author

Ok. Think we got it v_v; finally.

@dfop02
Copy link
Owner

dfop02 commented Dec 2, 2025

@raithedavion Great work! You forgot to change the target branch to release/1.1.2.
Please update it when you can and I’ll review everything again. 🙂

@raithedavion raithedavion changed the base branch from release/1.1.1 to release/1.1.2 December 2, 2025 00:43
@raithedavion
Copy link
Contributor Author

Done. Thought I had done that already lol

overrides to apply_styles_to_paragraph and
apply_styles_to_run methods).  )
Removed unused methods (migrated class and tag
@raithedavion
Copy link
Contributor Author

Done.

@dfop02
Copy link
Owner

dfop02 commented Dec 2, 2025

Awesome! I'll review it all again still this week, thanks for all your efforts!

@dfop02
Copy link
Owner

dfop02 commented Dec 4, 2025

hey @raithedavion I left 2 minor feedbacks, but looks pretty good, congrats!

@raithedavion
Copy link
Contributor Author

Ok. All done. I moved the parse_line_styles & the previous releases _parse_text_decorations to utils (neither used "self" so it made sense to move it too). And I added the style clearing for the h1-9 tags.

@dfop02 dfop02 merged commit f129f3e into dfop02:release/1.1.2 Dec 4, 2025
6 checks passed
@dfop02
Copy link
Owner

dfop02 commented Dec 4, 2025

Awesome @raithedavion ! Merged!

I have one more planned task for this release that I'll probably work on this weekend, so I'm planning to release the 1.1.2 until next week, just for let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation New Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants