-
-
Notifications
You must be signed in to change notification settings - Fork 13
Class map tag override #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class map tag override #44
Conversation
|
Requested changes made. Let me know if you want me to pull down your current "HISTORY" or if you want to manually merge that file. |
|
Thanks @raithedavion , I'll review all again this weekend :) |
|
Hi @raithedavion ! |
dfop02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a friendly reminder to review the updates on your PR. I left a few comments and also pushed the “html-comments” PR, so you’ll need to rebase and resolve the conflicts when you get a chance. Thanks!
|
Planning on getting it this weekend. Unfortunately had other priorities this week :D |
|
Changes implemented. |
|
@raithedavion I could you remove all the lint changes you introduced, focusing just on you changes? Recently merged a new feature and it introduced some conflicts in a few files. Could you please merge the latest Also, please be aware that PR #48 conflicts with some of your commits. I’m giving priority to reviewing and merging whichever PR addresses all changes and fixes first. You’re both doing a great job, and I’m looking forward to merging your contributions to help the project grow. |
|
@raithedavion Release 1.1.1 is officially out! 🎉 Also, please remove the lint adjustments for now to avoid additional conflicts. I was following the flake8 rules, but it looks like the test workflow isn’t running correctly and needs to be fixed later. I’m also considering switching to another linter, so if you have any suggestions, I’m open to new ideas. Let me know if you need any help or adjustments! |
…vion/html4docx into css-classes-tags/replay
Merge updated history & readme.
eb45941 to
df4bf85
Compare
Required changes + rebase to release/1.1.2.
|
Ok. Think we got it v_v; finally. |
|
@raithedavion Great work! You forgot to change the target branch to |
|
Done. Thought I had done that already lol |
overrides to apply_styles_to_paragraph and apply_styles_to_run methods). )
Removed unused methods (migrated class and tag
|
Done. |
|
Awesome! I'll review it all again still this week, thanks for all your efforts! |
|
hey @raithedavion I left 2 minor feedbacks, but looks pretty good, congrats! |
Added h1-9 tag to endtag inline style clearing.
Modifying based on new comments made by upstream.
|
Ok. All done. I moved the parse_line_styles & the previous releases _parse_text_decorations to utils (neither used "self" so it made sense to move it too). And I added the style clearing for the h1-9 tags. |
|
Awesome @raithedavion ! Merged! I have one more planned task for this release that I'll probably work on this weekend, so I'm planning to release the |
Description
Please provide a clear and concise description of your changes.
Explain what your PR does and why it's necessary.
I had a use case for using this in conjunction with a WYSIWYG editor, and I needed specific css classes that correspond to the editor to be mapped to specific styles in a template word document. So I made the required changes to the module and so far my local changes work very well.
Issue Reference
Link to the issue this PR addresses, if applicable.
Example: Fixes #123
Checklist Before Requesting a Review