Skip to content

Conversation

@Lynuxen
Copy link
Contributor

@Lynuxen Lynuxen commented Nov 21, 2025

Description

Added inline support for common CSS text properties for <p>, <span> and <h> tags.

Current support:

Formatting a paragraph:

  • text-align
  • line-height
  • margin-left
  • margin-right
  • text-indent

Formatting a run (can be used directly on a paragraph or header to format all runs)

  • font-weight: ('bold', 'bolder', '700', '800', '900', 'normal', 'lighter', '400', '300', '100')
  • font-style: ('italic', 'oblique', 'normal'')
  • text-decoration: ('underline', 'line-through') ('solid', 'double', 'dotted', 'dashed', 'wavy'), and the longhand properties (text-decoration-*)
  • text-transform: ('uppercase', 'lowercase', 'capitalize')
  • font-size
  • font-family
  • color
  • background-color: Paragraph and run highlight colors can now differ. Partial support on what can be used as a color.

Issue Reference

Fixes #47
Fixes #46.

There will most likely be a conflict with #44, as I started work before I noticed it and only saw it when creating this PR and checking the issues. I can rebase once #44 is merged or adjust as needed.

Checklist Before Requesting a Review

  • I have performed a self-review of my code.
  • My code follows the project's coding style and guidelines.
  • I have run tests and verified that all existing and new tests pass.
  • I have added new tests to cover my changes.

Preview

image image image image

@Lynuxen Lynuxen changed the title Feature/common text css Common CSS text properties Nov 21, 2025
@Lynuxen Lynuxen changed the base branch from main to release/1.1.1 November 21, 2025 02:53
@dfop02 dfop02 self-requested a review November 21, 2025 08:49
@dfop02 dfop02 self-assigned this Nov 21, 2025
@dfop02 dfop02 added bug Something isn't working documentation Improvements or additions to documentation New Feature New feature or request good first issue Good for newcomers labels Nov 21, 2025
Copy link
Owner

@dfop02 dfop02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments on your code. Please take a look when you have some time and let me know once you’ve addressed the changes or replied to everything.
Thanks again for your support in making this project a little better!

Lynuxen and others added 2 commits November 24, 2025 09:55
- Added longhand support for properties of text-decoration-*
- `background-color` improvements
- Performance and logic improvements
@Lynuxen Lynuxen requested a review from dfop02 November 24, 2025 08:08
@dfop02
Copy link
Owner

dfop02 commented Nov 25, 2025

@Lynuxen The PR looks good! I’d like to better understand your approach regarding how the styles are being applied. There’s also a test failing on Python 3.14, so please take a look when you get a chance.

Additionally, please be aware that PR #44 conflicts with some of your commits. I’m giving priority to reviewing and merging whichever PR fully addresses the required changes and fixes first. You’re both doing great work, and I’m looking forward to merging your contributions to help the project grow.

@dfop02 dfop02 mentioned this pull request Nov 25, 2025
4 tasks
@Lynuxen Lynuxen requested a review from dfop02 November 26, 2025 00:34
@dfop02
Copy link
Owner

dfop02 commented Nov 26, 2025

@Lynuxen keep failing on Python 3.14, I re-run the job twice just in case, same results.

@Lynuxen
Copy link
Contributor Author

Lynuxen commented Nov 26, 2025

@dfop02 All done.

@dfop02 dfop02 merged commit 6aa12f5 into dfop02:release/1.1.1 Nov 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers New Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlighting a word with background-color style property highlights the whole paragraph text-decoration style property for underline is not applied

3 participants