-
-
Notifications
You must be signed in to change notification settings - Fork 13
Common CSS text properties #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common CSS text properties #48
Conversation
dfop02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments on your code. Please take a look when you have some time and let me know once you’ve addressed the changes or replied to everything.
Thanks again for your support in making this project a little better!
- Added longhand support for properties of text-decoration-* - `background-color` improvements - Performance and logic improvements
|
@Lynuxen The PR looks good! I’d like to better understand your approach regarding how the styles are being applied. There’s also a test failing on Python 3.14, so please take a look when you get a chance. Additionally, please be aware that PR #44 conflicts with some of your commits. I’m giving priority to reviewing and merging whichever PR fully addresses the required changes and fixes first. You’re both doing great work, and I’m looking forward to merging your contributions to help the project grow. |
|
@Lynuxen keep failing on Python 3.14, I re-run the job twice just in case, same results. |
|
@dfop02 All done. |
Description
Added inline support for common CSS text properties for
<p>,<span>and<h>tags.Current support:
Formatting a paragraph:
Formatting a run (can be used directly on a paragraph or header to format all runs)
Issue Reference
Fixes #47
Fixes #46.
There will most likely be a conflict with #44, as I started work before I noticed it and only saw it when creating this PR and checking the issues. I can rebase once #44 is merged or adjust as needed.
Checklist Before Requesting a Review
Preview