Skip to content

Conversation

@dpetran
Copy link
Contributor

@dpetran dpetran commented Jun 4, 2025

dpetran added 5 commits June 4, 2025 16:33
We unfortunately cannot register policies in the tracker while wrapping policies, since
a db may come in pre-wrapped by a call to `wrap-policy`. We must instead check the db
itself for whatever policies it has been wrapped with and initialize tracking of those.
These expectations were incorrect and reflected the reuse of the db policy
tracer. Modify policies are /not/ evaluated during the execution of a query, and the
report that stated they were was erroneous.
@dpetran dpetran requested a review from a team June 4, 2025 21:55
Copy link
Contributor

@zonotope zonotope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I know this builds on #1030. I'm reviewing that now.

Copy link
Contributor

@zonotope zonotope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔑

@dpetran dpetran mentioned this pull request Jul 2, 2025
@dpetran
Copy link
Contributor Author

dpetran commented Jul 2, 2025

This is getting held up by #1030, so I've cherry-picked it over to main. Superseded by #1049.

@dpetran dpetran closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants