Fix/policy tracking2 #1049
Merged
Fix/policy tracking2 #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We unfortunately cannot register policies in the tracker while wrapping policies, since a db may come in pre-wrapped by a call to `wrap-policy`. We must instead check the db itself for whatever policies it has been wrapped with and initialize tracking of those.
These expectations were incorrect and reflected the reuse of the db policy tracer. Modify policies are /not/ evaluated during the execution of a query, and the report that stated they were was erroneous.
dpetran
force-pushed
the
fix/policy-tracking2
branch
from
527da00 to
306319a
Compare
Closed
dpetran
force-pushed
the
fix/policy-tracking2
branch
from
306319a to
f083b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/fluree/core/issues/179
This is the approved #1031 cherry picked onto main, since it was behind another PR that requires additional review.
Moves policy execution tracking out the Db record and into the tracker.