-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Improve health check #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| } | ||
|
|
||
| fn submit(&mut self, message: Message<TPayload>) -> Result<(), SubmitError<TPayload>> { | ||
| self.iterations_since_last_submit = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we should check if submit was successful before reseting this counter
| path: PathBuf, | ||
| interval: Duration, | ||
| deadline: SystemTime, | ||
| iterations_since_last_submit: u64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using a u64, but maybe we can get away with a u32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify in your commit message when we would end up in the situation where those two conditions are not met?
Also, can you add tests?
|
As this is something you are testing for the Snuba consumer I would do this inside the snuba consumer code rather than the standard HealthCheck in the arroyo code base. |
Instead of touching the health file every time we call poll, we only touch it when one of the following two conditions is true: