Skip to content

feat: Improve health check #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidtsuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Improve health check #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions rust-arroyo/src/processing/strategies/healthcheck.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ pub struct HealthCheck<Next> {
path: PathBuf,
interval: Duration,
deadline: SystemTime,
iterations_since_last_submit: u64,
Copy link
Contributor Author

@davidtsuk davidtsuk May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using a u64, but maybe we can get away with a u32

}

impl<Next> HealthCheck<Next> {
Expand All @@ -26,6 +27,7 @@ impl<Next> HealthCheck<Next> {
path: path.into(),
interval,
deadline,
iterations_since_last_submit: 0,
}
}

Expand All @@ -50,12 +52,21 @@ where
Next: ProcessingStrategy<TPayload> + 'static,
{
fn poll(&mut self) -> Result<Option<CommitRequest>, StrategyError> {
self.maybe_touch_file();
let poll_result = self.next_step.poll();
if let Ok(Some(_commit_request)) = poll_result.as_ref() {
self.maybe_touch_file();
}

if self.iterations_since_last_submit > 0 {
self.maybe_touch_file();
}

self.next_step.poll()
self.iterations_since_last_submit += 1;
poll_result
}

fn submit(&mut self, message: Message<TPayload>) -> Result<(), SubmitError<TPayload>> {
self.iterations_since_last_submit = 0;
Copy link
Contributor Author

@davidtsuk davidtsuk May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we should check if submit was successful before reseting this counter

self.next_step.submit(message)
}

Expand Down
Loading