refactor(gists): migrate gists.go to NewTool pattern #1591
+580
−543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert GetMe, GetTeams, and GetTeamMembers to use the new typed dependency injection pattern: - Functions now take only translations helper, return toolsets.ServerTool - Handler is generated lazily via deps.GetClient/deps.GetGQLClient - Tests updated to use serverTool.Handler(deps) pattern - Fixed error return pattern to return nil for Go error (via result.IsError) Co-authored-by: Adam Holt <oholt@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates gist-related tools to the new NewTool pattern with dependency injection, removing the getClient parameter from function signatures and using ToolDependencies instead. This is part of a stacked PR series refactoring the ServerTool architecture.
- Removes
getClientparameter from all gist tool functions - Adopts
NewToolpattern withToolDependenciesfor dependency injection - Standardizes error handling using
utils.NewToolResultErrorFromErr - Updates all tests to use the new
serverTool.Handler(deps)pattern withresult.IsErrorchecks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/gists.go | Refactored all four gist tools (ListGists, GetGist, CreateGist, UpdateGist) to use NewTool pattern with ToolDependencies, standardized error handling, and removed getClient parameter |
| pkg/github/tools.go | Updated gist toolset registration to remove NewServerToolLegacy wrapper and call tool functions without getClient parameter |
| pkg/github/gists_test.go | Updated all test cases to use new pattern with serverTool.Handler(deps), replaced error checking with result.IsError assertions, and added getErrorResult helper usage |
This was referenced Dec 13, 2025
Convert all gist tools (ListGists, GetGist, CreateGist, UpdateGist) to use the new NewTool helper with ToolDependencies injection. - Remove getClient parameter from function signatures - Use deps.GetClient(ctx) inside handlers - Standardize error handling with utils.NewToolResultErrorFromErr() - Update all tests to use serverTool.Handler(deps) pattern Co-authored-by: Adam Holt <omgitsads@users.noreply.github.com>
SamMorrowDrums
force-pushed
the
SamMorrowDrums/server-tool-refactor-gists
branch
from
af97440 to
820ce1e
Compare
SamMorrowDrums
force-pushed
the
SamMorrowDrums/server-tool-refactor-context-tools
branch
from
07249a0 to
b863da9
Compare
This was referenced Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all gist tools (
ListGists,GetGist,CreateGist,UpdateGist) to the newNewToolpattern withToolDependenciesinjection.Part of stacked PRs for ServerTool refactoring:
Changes
getClientparameter from all gist function signaturest translations.TranslationHelperFuncand returntoolsets.ServerTooldeps.GetClient(ctx)inside handlers to get the GitHub clientutils.NewToolResultErrorFromErr()instead offmt.ErrorfserverTool.Handler(deps)pattern withresult.IsErrorchecksTesting
script/lintpassesscript/testpassesCo-authored-by: Adam Holt oholt@github.com