Skip to content

aa_Latn: revert and update data #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simoncozens merged 3 commits into from
Nov 3, 2025
Merged

aa_Latn: revert and update data #247

simoncozens merged 3 commits into from
Nov 3, 2025

Conversation

@moyogo
Copy link
Contributor

@moyogo moyogo commented Nov 2, 2025

simoncozens
simoncozens reviewed Nov 3, 2025
View reviewed changes
Lib/gflanguages/data/languages/aa_Latn.textproto Outdated
exemplar_chars {
base: "A B C D E F G H I J K L M N O P Q R S T U V W X Y Z a b c d e f g h i j k l m n o p q r s t u v w x y z"
base: "A B C D E F G H I J K L M N O P Q R S T U V W X Y Z a b c d e f g h i j k l m n o p q r s t u v w x y z Á á Â â É é Ê ê Í í Î î Ó ó Ô ô Ú ú Û û"
marks: "◌̀ ◌́ ◌̂"
Copy link
Contributor

@simoncozens simoncozens Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're at the point of saying that "marks:" refers to "productive marks" which can essentially be added to any base. If the only accented letters are those you've given in the bases, we don't need this line.

@simoncozens
Copy link
Contributor

simoncozens commented Nov 3, 2025

Thank you!

@simoncozens simoncozens merged commit 335f4db into googlefonts:main Nov 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simoncozens simoncozens simoncozens left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moyogo @simoncozens