Added github-handle variable for Bonnie Wolf #8419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-handle variable will eventually replace github and picture variables reducing redundancy
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
Member
|
Review ETA: 5 PM 11/14/25 |
myronchen-git
requested changes
Nov 13, 2025
Member
myronchen-git
left a comment
myronchen-git
left a comment
There was a problem hiding this comment.
Congratulations on finishing a good first issue.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The pull request title is named properly.
- The why in the pull request description is adequately described.
- Code changes have been correctly made.
- In the issue, you've correctly assigned yourself.
- In the issue, you've correctly set the project status.
- In the issue, action items have correctly been checked off.
- In the issue, you've properly gave your availability and ETA.
Changes that need to be made
- In the screenshot section, please remove the empty before and after placeholders. There is a note, when you edit it, that tells you what to put when there aren't any visual changes.
Optional recommendations
- In this pull request's description, the description of what changes were made could be more specific and descriptive.
github-project-automation
bot
moved this from PR Needs review
to PRs being reviewed
in P: HfLA Website: Project Board
Member
Author
|
updated pull request per suggestion from reviewer @myronchen-git and requested re-review. |
Member
|
Review ETA: EOD 11/13/25 |
34 tasks
aymeviviana
approved these changes
Nov 14, 2025
Member
aymeviviana
left a comment
aymeviviana
left a comment
There was a problem hiding this comment.
Well done, @abinetabate1 ! Thank you for your work on this issue 😀
Done Correctly:
- Pull Request contains the correct branch
- The issue is correctly linked
- CodeQL Alerts section is correctly completed
- Code update is applicable and clean
- Change looks consistent across multiple screen sizes
Approved!
aadilahmed
approved these changes
Nov 14, 2025
Member
aadilahmed
left a comment
aadilahmed
left a comment
There was a problem hiding this comment.
Great work! I see that you've added the github-handle variable to the youthjusticenav.md file, and the website is unchanged. Good job on this issue!
myronchen-git
approved these changes
Nov 14, 2025
github-project-automation
bot
moved this from PRs being reviewed
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7332
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website