Skip to content

Conversation

@MohamedTwahir
Copy link
Member

@MohamedTwahir MohamedTwahir commented Nov 18, 2025

Fixes #7858

What changes did you make?

  • removed unused slack icon

Why did you make the changes (we will use this info to test)?

  • It was needed to maintain a clean file folders

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

- No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b MohamedTwahir-unused-slack-icon-7858 gh-pages
git pull https://github.com/MohamedTwahir/website.git unused-slack-icon-7858

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 18, 2025
@santi-jose santi-jose self-assigned this Nov 19, 2025
@santi-jose
Copy link
Member

santi-jose commented Nov 19, 2025

Review ETA: 8PM 11/19/2025
Availability: 5PM - 9PM Monday - Friday

Copy link
Member

@santi-jose santi-jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MohamedTwahir ,
Good job working on this issue!

What you did well:

  1. Created pull request from and into branches properly
  2. Properly checked CodeQL Alerts
  3. Removed unused file slack-self-invite.svg
  4. Changes did not affect the rest of the website

I approve this PR!

@lastCoyotes lastCoyotes self-requested a review November 20, 2025 06:03
@lastCoyotes
Copy link
Member

Review ETA: by 10:30PM 11/19/25
Availability: 4PM - 7PM Monday - Thursday

Copy link
Member

@lastCoyotes lastCoyotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the .svg fulfills the pull request, and no other issues or alerts were found. No visual changes to report of either. I approve of this PR!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 20, 2025
@DDVVPP DDVVPP merged commit 902f371 into hackforla:gh-pages Nov 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Remove unused Slack icon slack-self-invite.svg

4 participants