feat(ios): enhance updateUser error messages with detailed diagnostics #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve error messages returned from updateUser by including: - Error code and domain for easier debugging - Descriptive error message with context - Underlying error details when available This change is purely additive - it preserves all original error properties and maintains NSNull safety through removeNullUnderlyingError. Before: "Error in updateUser" After: "updateUser failed with error code -1012: Response body is empty for HTTP 200. Domain: io.intercom.ios.error.network"
Contributor
Author
|
Closing this PR. On reflection, the existing error handling is sufficient - detailed error information is already available in the error object (error.userInfo, error.domain, error.code) for integrators who need it. Promoting this to the error message string could inadvertently expose PII in logging tools like Sentry, which typically auto-capture error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves error messages returned from
updateUseron iOS by including detailed diagnostic information.Changes
detailedMessage,errorCode,errorDomain, and underlying error informationBefore/After
Before:
After:
Safety
removeNullUnderlyingErrormethodTesting
Tested with intercepted network requests returning various error conditions:
Error messages now provide actionable debugging information.