Skip to content

feat(ios): enhance updateUser error messages with detailed diagnostics #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IAmConorNolan wants to merge 3 commits into from
Closed

feat(ios): enhance updateUser error messages with detailed diagnostics #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79c3c0a
feat(ios): enhance updateUser error messages with detailed diagnostics
IAmConorNolan Dec 15, 2025
75492fa
ci: switch CircleCI resource class to m4pro.medium
IAmConorNolan Dec 15, 2025
a9a91c9
ci: update Xcode version to 26.2.0 for m4pro.medium compatibility
IAmConorNolan Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ version: 2.1
# Default VM config to be used for macOS builds
macos_config: &macos_config
macos:
xcode: 16.0.0
resource_class: macos.m1.large.gen1
xcode: 26.2.0
resource_class: m4pro.medium
shell: /bin/bash --login -eo pipefail

setup_env_file: &setup_env_file
Expand Down
24 changes: 23 additions & 1 deletion ios/IntercomModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,29 @@ - (NSData *)dataFromHexString:(NSString *)string {
[Intercom updateUser:userAttributes success:^{
resolve(@(YES));
} failure:^(NSError * _Nonnull error) {
failureCallback(UPDATE_USER, @"Error in updateUser", [self removeNullUnderlyingError:error]);
NSString *errorMessage = [NSString stringWithFormat:@"updateUser failed with error code %ld: %@. Domain: %@",
(long)error.code,
error.localizedDescription ?: @"<no description>",
error.domain ?: @"<no domain>"];

NSMutableDictionary *userInfo = [NSMutableDictionary dictionaryWithDictionary:error.userInfo ?: @{}];
userInfo[@"detailedMessage"] = errorMessage;
userInfo[@"errorCode"] = @(error.code);
userInfo[@"errorDomain"] = error.domain ?: @"";

if (error.userInfo[@"NSUnderlyingError"]) {
NSError *underlyingError = error.userInfo[@"NSUnderlyingError"];
if (![underlyingError isKindOfClass:[NSNull class]]) {
userInfo[@"underlyingErrorDescription"] = underlyingError.localizedDescription ?: @"";
userInfo[@"underlyingErrorCode"] = @(underlyingError.code);
}
}

NSError *enrichedError = [NSError errorWithDomain:error.domain
code:error.code
userInfo:userInfo];

failureCallback(UPDATE_USER, errorMessage, [self removeNullUnderlyingError:enrichedError]);
}];
};

Expand Down