Skip to content

Conversation

@gammazero
Copy link
Contributor

Since IPIP-378 is not moving forward, the legacy API is not deprecated because there nothing to replace it.

Since [IPIP-378](ipfs/specs#378) is not moving forward, the legacy API is not deprecated because there nothing to replace it.
@gammazero gammazero requested a review from a team as a code owner December 2, 2025 18:10
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.11%. Comparing base (23312e7) to head (98e62c3).
⚠️ Report is 5 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1075   +/-   ##
=======================================
  Coverage   61.10%   61.11%           
=======================================
  Files         264      264           
  Lines       26215    26215           
=======================================
+ Hits        16019    16021    +2     
  Misses       8519     8519           
+ Partials     1677     1675    -2     
Files with missing lines Coverage Δ
routing/http/server/server.go 76.15% <ø> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gammazero gammazero changed the title delegated-routing: un-deprecate legacy delegated routing API routing: un-deprecate legacy delegated routing API Dec 2, 2025
@gammazero gammazero requested a review from lidel December 2, 2025 18:49
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @aschmahmann and @gammazero we decided to keep this deprecated.

My thinking is: close this, and instead update godoc in #1076 to reference more relevant IPIP.

Thoughts?

@gammazero
Copy link
Contributor Author

Thoughts?

... Closing

@gammazero gammazero closed this Dec 3, 2025
@gammazero gammazero deleted the undeprecate-delegated-routing-api branch December 3, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants