Skip to content

routing: un-deprecate legacy delegated routing API #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gammazero wants to merge 2 commits into from
+5 −13
Closed

routing: un-deprecate legacy delegated routing API #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20d81a1
delegated-routing: un-deprecate legacy delegated routing API
gammazero Dec 2, 2025
98e62c3
remove linter ignores
gammazero Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions routing/http/client/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ func (m *mockContentRouter) FindProviders(ctx context.Context, key cid.Cid, limi
return args.Get(0).(iter.ResultIter[types.Record]), args.Error(1)
}

//nolint:staticcheck
//lint:ignore SA1019 // ignore staticcheck
func (m *mockContentRouter) ProvideBitswap(ctx context.Context, req *server.BitswapWriteProvideRequest) (time.Duration, error) {
args := m.Called(ctx, req)
return args.Get(0).(time.Duration), args.Error(1)
Expand Down Expand Up @@ -503,8 +501,6 @@ func TestClient_Provide(t *testing.T) {
}
}

//nolint:staticcheck
//lint:ignore SA1019 // ignore staticcheck
expectedProvReq := &server.BitswapWriteProvideRequest{
Keys: c.cids,
Timestamp: clock.Now().Truncate(time.Millisecond),
Expand Down
14 changes: 5 additions & 9 deletions routing/http/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,8 @@ type DelegatedRouter interface {
// Limit indicates the maximum amount of results to return; 0 means unbounded.
FindProviders(ctx context.Context, cid cid.Cid, limit int) (iter.ResultIter[types.Record], error)

// Deprecated: protocol-agnostic provide is being worked on in [IPIP-378]:
//
// [IPIP-378]: https://github.com/ipfs/specs/pull/378
// ProvideBitswap tells a delegated router to advertise the CIDs in the
// request as content that is available over bitswap.
ProvideBitswap(ctx context.Context, req *BitswapWriteProvideRequest) (time.Duration, error)

// FindPeers searches for peers who have the provided [peer.ID].
Expand All @@ -95,9 +94,8 @@ type DelegatedRouter interface {
// Deprecated: use DelegatedRouter. ContentRouter will be removed in a future version.
type ContentRouter = DelegatedRouter

// Deprecated: protocol-agnostic provide is being worked on in [IPIP-378]:
//
// [IPIP-378]: https://github.com/ipfs/specs/pull/378
// BitswapWriteProvideRequest is a request for a delegated router to advertise
// CIDs of content that is retrievable over bitswap.
type BitswapWriteProvideRequest struct {
Keys []cid.Cid
Timestamp time.Time
Expand All @@ -106,9 +104,7 @@ type BitswapWriteProvideRequest struct {
Addrs []multiaddr.Multiaddr
}

// Deprecated: protocol-agnostic provide is being worked on in [IPIP-378]:
//
// [IPIP-378]: https://github.com/ipfs/specs/pull/378
// WriteProvideRequest is a wrapper for any protocol-specific provide requests.
type WriteProvideRequest struct {
Protocol string
Schema string
Expand Down