fix: winningTicketRedeemedEvents query defaults to 100 rows #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds pagination support to the winningTicketRedeemedEvents GraphQL query to fix an issue where only the first 100 rows were retrieved. The changes enable proper pagination for transaction history, allowing users to load additional winning ticket events as they scroll.
Changes:
- Added
firstandskippagination parameters to thewinningTicketRedeemedEventsGraphQL query - Updated the React component to merge paginated winning ticket events with transaction events
- Regenerated TypeScript types from the updated GraphQL schema
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| queries/transactions.graphql | Added pagination parameters (first and skip) to winningTicketRedeemedEvents query |
| components/HistoryView/index.tsx | Updated fetchMore logic to concatenate paginated winningTicketRedeemedEvents arrays |
| apollo/subgraph.ts | Auto-generated TypeScript types from GraphQL schema updates (BroadcasterDay, TreasuryVote, etc.) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the way transaction and winning ticket events are fetched and merged in the history view, ensuring more accurate pagination and event filtering. The main changes include improvements to the GraphQL query and the merging logic in the React component.
History view data fetching improvements:
transactionsquery (particularly thewinningTicketRedeemedEventspart) to support pagination by adding thefirstandskipparameters, allowing for more flexible and efficient data retrieval. Initially, this simply grabbed the first 100 rows, and would not go beyond this even if the user wanted to see more transactions.