fix: ask for language and browser install #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Oct 7, 2025
| .option('--ct', 'install Playwright Component testing') | ||
| .option('--quiet', 'do not ask for interactive input prompts') | ||
| .option('--gha', 'install GitHub Actions') | ||
| .option('--lang <language>', 'language to use (js, TypeScript)', 'TypeScript') |
Member
Author
There was a problem hiding this comment.
oh, then let's remove all the code that goes with it!
Member
There was a problem hiding this comment.
It was inadvertent change, but I am for removing the code related to js.
yury-s
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
39fa746 regressed the language and browser installation questions by providing default values to Commander.js, which meant we always set
skip: trueon those questions. Fixing by turning them back into optionals, the questionnaire makes sure we set default values. Closes microsoft/playwright#37742.